-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uninstaller is not signed by electron-builder reason=custom NSIS script is used #4383
Comments
Hey, we have similar issue.
Any ideas why uninstaller does not exist? |
@bimusiek same issue here! The code signing works for all the other files before. But the uninstaller exe is missing for unknown reason. |
@MatthiasD0 I was able to fix it by... installing all updates to Windows in Parallels. |
@bimusiek can you please tell me how did you get a .p12 file for EV signing on Windows? 🙏 Provider (Comodo) sent me a USB token with the certificate on it, but cert/key are not exportable to file. |
@damianobarbati I have exactly the same question. |
I bought |
@bimusiek and now the most imporant question: does you .exe installer (signed with it) pass the smartscreen deathly screen? This could be the holy grail to me. |
@damianobarbati Yes, there is no screen when installing. When running exe, it installs the app and opens it directly. I just checked on Windows 10 (via Parallel). |
@damianobarbati : could you please share your experience with code signing when you get it work? |
@kzimny I already code-sign my application but I have the crappy USB token Sectigo (ex Comodo) sent me. |
@damianobarbati We have CI that builds our app, so I cannot imagine how we could do it with physical device 😮 I can try later with assisted installer, but I don't believe it would be any different. |
@bimusiek I'd really appreciate your try and confirm on this 🙏 |
@damianobarbati how did you signed your app? Could you please share the responsible configuration? |
@damianobarbati Worked like a charm, no extra screen when running exe. Zipped exe file for you to try: |
@kzimny here what I have so far: . install Parallels Desktop Pro and create a Windows 10 virtual machine with a Windows 10 image download from https://www.microsoft.com/it-it/software-download/windows10ISO (do not use the default parallels image for WIN10) . install SafeNet Client (https://support.comodo.com/index.php?/Knowledgebase/Article/View/1211/106/safenet-download-for-ev-codesigning-certificates) . attach the USB token permanently to the virtual machine (Device/USB settings) . open SafeNet > config > Enable single logon (otherwise you'll be prompt for password 57862 times when signing) Here my config (omitted the mac part):
Build command:
|
@bimusiek thanks so much, definitely the way to go !!! |
Thank you very much @damianobarbati |
@bimusiek bad news, I tried the "Microsoft Authenticode" and is not working. First thing I noted, when I exported it from Internet Explorer it was labelled as "extendend validation". I think you've build enough trust somehow and now SmartScreen does not consider your application as a menace. So nevermind, dongle is still the only way to be 100% sure to bypass the SmartScreen of death 😔 Thanks anyway for your help. |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Seems to be the issue in my case. (I am using windows shared runners in gitlab). I was using And I think I found the reason for this. Since we are running in Windows, the in-built "Microsoft Security" app (Defender? Security Essentials?) is basically identifying it as Trojan Virus.
Not sure if this my PC or for everyone... But I do not get any Trojan errors while using |
@bimusiek still not working for me with version 21.2.0, same with version 20.44.4 |
@lvbeck We have created new repo with brand new code and it still worked. Did you try to install all Window updates and make sure no antivirus is blocking signing executable? |
today I updated electron-builder to latest version 22.6.0, but another error occurred:
|
yes I see that same error when upgrading to 22.6.0 |
Hi. I have such config:
And just copy of default NSIS template of electron-builder.
I am getting error:
I can not understand where to get this uninstall.exe (<= main question) and how to sign it?
The text was updated successfully, but these errors were encountered: