Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build project #94

Closed
asaf050 opened this issue Feb 13, 2018 · 7 comments
Closed

Unable to build project #94

asaf050 opened this issue Feb 13, 2018 · 7 comments
Labels

Comments

@asaf050
Copy link

asaf050 commented Feb 13, 2018

Hello ,

I'm coming across an issue when try to build the project.
I'm getting the following error:
/home/ubuntu/Workspace/Projects/electron-webpack-quick-start/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:276 throw new Error( ^ Error: original.line and original.column are not numbers -- you probably meant to omit the original mapping entirely and only map the generated position. If so, pass null for the original mapping instead of an object with empty or null values.

node: 8.9.4
npm: 5.6.0
yarn: 1.3.2

Step to reproduce:

  1. Clone electron-webpack-quick-start
  2. Run yarn
  3. Run yarn dist
@loopmode
Copy link
Collaborator

This is a known issue and there is a workaround, see mozilla/source-map#304 (comment)

@dracan
Copy link

dracan commented Feb 16, 2018

To save everyone having to track down the workaround, just put "webpack-sources": "1.0.1" in your package.json to force that version until this is fixed.

@delaneyj
Copy link

I'm windows with a working (for dev) TS/Vue setup. Adding "webpack-sources": "1.0.1" to package.json deleted node_modules and rebuilt. Still getting this same error. Could I be missing something else?

{
  "name": "electron-webpack-quick-start",
  "version": "0.0.0",
  "license": "MIT",
  "scripts": {
    "dev": "electron-webpack dev",
    "compile": "electron-webpack",
    "dist": "yarn compile && electron-builder",
    "dist:dir": "yarn dist --dir -c.compression=store -c.mac.identity=null"
  },
  "dependencies": {
    "@types/animejs": "^2.0.0",
    "@types/three": "^0.89.10",
    "animejs": "^2.2.0",
    "source-map-support": "^0.5.3",
    "three": "^0.90.0",
    "vue-property-decorator": "^6.0.0",
    "vue-router": "^3.0.1",
    "vuex": "^3.0.1",
    "webpack-sources": "1.0.1"
  },
  "devDependencies": {
    "electron": "1.7.12",
    "electron-builder": "^19.56.0",
    "electron-webpack": "1.12.1",
    "electron-webpack-ts": "^1.3.0",
    "electron-webpack-vue": "^1.3.0",
    "node-sass": "^4.7.2",
    "sass-loader": "^6.0.6",
    "typescript": "^2.7.2",
    "vue": "^2.5.13",
    "webpack": "^3.10.0"
  }
}

@dracan
Copy link

dracan commented Feb 19, 2018

@delaneyj Not sure, but I'm using Windows and Vue (but without Typescript), which does work. The project I'm using it for is here: https://github.com/dracan/tomatoad if that helps at all.

@loopmode
Copy link
Collaborator

loopmode commented Feb 23, 2018

Hmm @dracan has it in devDependencies, while you have it in dependencies.
I would still suggest using resolutions instead, because you don't know what your sub-dependencies might depend on! They might still use their own version, desprite of what version your own project depends on.

See https://yarnpkg.com/lang/en/docs/selective-version-resolutions/#toc-why-would-you-want-to-do-this

@develar develar closed this as completed Mar 18, 2018
@loopmode
Copy link
Collaborator

loopmode commented May 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants