Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate all images are actually images during the tests #431

Open
MarshallOfSound opened this issue Dec 16, 2017 · 2 comments · May be fixed by baby636/apps#17
Open

Validate all images are actually images during the tests #431

MarshallOfSound opened this issue Dec 16, 2017 · 2 comments · May be fixed by baby636/apps#17
Labels
good first issue

Comments

@MarshallOfSound
Copy link
Member

We could do a HEAD request to all image URL's to ensure the mimeType returned is actually an image.

This would prevent things like #430 where the URL added didn't actually point to an image 👍

Existing tests: https://github.com/electron/electron-apps/blob/master/test/human-data.js#L100
@MarshallOfSound MarshallOfSound mentioned this issue Dec 16, 2017
Merged
@zeke
Copy link
Contributor

zeke commented Dec 20, 2017

Yeah I had a similar thought a while back: #88

We'd need to make sure this check only happens on newly-added (or newly updated) apps, so as to avoid making a jillion network requests. :)

@as900900

This comment has been minimized.

Sign in to view
@baby636 baby636 linked a pull request Apr 24, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Fix for 1 vulnerabilities baby636/apps
3 participants
@zeke @MarshallOfSound @as900900