Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search in upgraded encrypted rooms doesn't search pre-upgrade history #909

Open
rda0 opened this issue Sep 28, 2021 · 4 comments
Open

Search in upgraded encrypted rooms doesn't search pre-upgrade history #909

rda0 opened this issue Sep 28, 2021 · 4 comments
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@rda0
Copy link

rda0 commented Sep 28, 2021

Steps to reproduce

  1. Create a private encrypted room (version 6)
  2. Send message foo
  3. Upgrade the room (version 9)
  4. Search for foo in the new room (version 9)
  5. Search for foo in the old room (version 6)

What did you expect?

Search results across upgraded rooms.

What happened?

Searches in (4) and (5) do not show any results:

image

Sometimes however (4) and/or (5) do show some search results.

Operating system

Windows

Application version

Element version: 1.9.0 Olm version: 3.2.3

How did you install the app?

https://element.io/get-started

Homeserver

phys.ethz.ch

Have you submitted a rageshake?

Yes

@rda0 rda0 added the T-Defect label Sep 28, 2021
@SimonBrandner SimonBrandner added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Sep 29, 2021
@kittykat
Copy link

kittykat commented Sep 30, 2021

@rda0 Can you please test and confirm that the search works before the room upgrade? (between step 2 and 3)

@rda0
Copy link
Author

rda0 commented Oct 1, 2021

@kittykat I can confirm that the search works between step 2 and 3.

@novocaine
Copy link
Contributor

novocaine commented Oct 4, 2021

I can reproduce just by upgrading from 6 to 7.

Old room

Screenshot 2021-10-12 at 17 33 40

Upgraded room

Screenshot 2021-10-12 at 17 34 08

Searching the upgraded room for foo (text in the old room) doesn't work

Screenshot 2021-10-12 at 17 34 48

Searching the upgraded room for foobar (text in the new room) works

Screenshot 2021-10-12 at 17 35 17

@novocaine novocaine changed the title Searching in upgraded encrypted rooms does not always work Search in upgraded encrypted rooms doesn't search pre-upgrade history Oct 4, 2021
@golanv
Copy link

golanv commented Feb 26, 2023

For what it's worth, I noticed the same behavior. Search seems to work as expected for non-encrypted rooms though. This actually makes me a little reluctant to upgrade some rooms, as I have some users who seem to rely heavily on search.

@t3chguy t3chguy transferred this issue from element-hq/element-web Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

5 participants