Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited events that get redacted show their content #10191

Closed
bwindels opened this issue Jun 27, 2019 · 4 comments
Closed

Edited events that get redacted show their content #10191

bwindels opened this issue Jun 27, 2019 · 4 comments

Comments

@bwindels
Copy link
Contributor

bwindels commented Jun 27, 2019

How to repro:

image

On other clients present in the room with editing turned off, the original message appears correctly redacted without the content shown:

image

So seems like the client preserved state somehow.

Potentially related: #10006

@bwindels bwindels changed the title edit events that get redacted show their content when turning edits off in labs Edited events that gets redacted show their content when turning edits off in labs Jun 27, 2019
@jryans jryans self-assigned this Jul 5, 2019
@jryans
Copy link
Collaborator

jryans commented Jul 8, 2019

Hmm, I can't seem to reproduce this (attempted in both room encryption states). I tried a fast local HS and also slow matrix.org HS. @bwindels, could you retest? Maybe it's been fixed by other changes?

@bwindels
Copy link
Contributor Author

bwindels commented Jul 8, 2019

Will do!

@bwindels
Copy link
Contributor Author

bwindels commented Jul 8, 2019

Indeed, can't repro anymore with the above steps.

@bwindels bwindels closed this as completed Jul 8, 2019
@jryans jryans removed their assignment Jul 8, 2019
@bwindels
Copy link
Contributor Author

bwindels commented Jul 17, 2019

Found a way to repro this, you need two riot sessions:

  1. open riot with session 1
  2. send a message
  3. edit it
  4. redact it
  5. send +10 messages to trigger a limited sync in session 2 later on
  6. open riot with session 2, let it sync
  7. the edited and then redacted message should now have its content visible through the redaction lozenge.

@bwindels bwindels reopened this Jul 17, 2019
@jryans jryans changed the title Edited events that gets redacted show their content when turning edits off in labs Edited events that get redacted show their content Jul 17, 2019
@jryans jryans closed this as completed Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants