-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override, inherit, and default global and room URL preview settings #16852
Comments
Hmmm, you should be able to do this in the room settings. I do wonder how is the general settings related and why it doesn't work |
If I do it in room settings, wouldn't it be disabled for everyone in the room? You know what, maybe a global boolean setting isn't enough. It would be better as a tristate setting:
Especially the "by default" wording is confusing. I want them off by default. But then the room setting is the "non default", as it were, that overrides MY setting? Or is it the other way around? Either way it's confusing me now. |
Ok, then my argument goes for URL previews in rooms. Whether they are disabled or enabled by default, there's no setting "take general setting". Both settings are boolean, which is confusing. If I disable them by default and enable them in room settings, what's the result? And vice versa? I just don't understand what "by default" in the global setting is supposed to mean. If there's a default setting that's always overridden by a room setting, then why isn't there a setting to not override the global setting? So again, if not the global setting, then the room setting should be tristate:
|
these need a bit of a redesign imo, and it needs to be made more clear what overrides what. the global settings could offer the options
and the room settings to complement it:
the room settings should also offer these 3 distinct settings such that when e.g. you have default on and room on, then switch default off, you end up with default off and room on. |
Description
The URL previews feature has no effect. Turning it off in the preferences still enables them:
Steps to reproduce
Describe how what happens differs from what you expected.
Very simple: if I turn off URL previews, I want them turned off. There's really not much more to it.
Logs being sent: yes
Version information
The text was updated successfully, but these errors were encountered: