Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override, inherit, and default global and room URL preview settings #16852

Open
thany opened this issue Apr 2, 2021 · 5 comments
Open

Override, inherit, and default global and room URL preview settings #16852

thany opened this issue Apr 2, 2021 · 5 comments

Comments

@thany
Copy link

thany commented Apr 2, 2021

Description

The URL previews feature has no effect. Turning it off in the preferences still enables them:

image

Steps to reproduce

  1. Make URL previews work first, probably by turning this feature on
  2. Now turn it off
  3. I guess that's all?

Describe how what happens differs from what you expected.

Very simple: if I turn off URL previews, I want them turned off. There's really not much more to it.

Logs being sent: yes

Version information

  • Platform: desktop
  • OS: Windows 10
  • Version: 1.7.24
@thany thany added the T-Defect label Apr 2, 2021
@SimonBrandner
Copy link
Contributor

Hmmm, you should be able to do this in the room settings. I do wonder how is the general settings related and why it doesn't work

@thany
Copy link
Author

thany commented Apr 4, 2021

If I do it in room settings, wouldn't it be disabled for everyone in the room?

You know what, maybe a global boolean setting isn't enough. It would be better as a tristate setting:

  • Force on
  • Force off
  • Use room setting

Especially the "by default" wording is confusing. I want them off by default. But then the room setting is the "non default", as it were, that overrides MY setting? Or is it the other way around? Either way it's confusing me now.

@jellykells
Copy link

If I do it in room settings, wouldn't it be disabled for everyone in the room?

No, it only affects you
Screenshot_20210405

@thany
Copy link
Author

thany commented Apr 6, 2021

Ok, then my argument goes for URL previews in rooms.

Whether they are disabled or enabled by default, there's no setting "take general setting". Both settings are boolean, which is confusing. If I disable them by default and enable them in room settings, what's the result? And vice versa? I just don't understand what "by default" in the global setting is supposed to mean.

If there's a default setting that's always overridden by a room setting, then why isn't there a setting to not override the global setting?

So again, if not the global setting, then the room setting should be tristate:

  • Enable
  • Disabe
  • Take global setting

@HarHarLinks
Copy link

these need a bit of a redesign imo, and it needs to be made more clear what overrides what.

the global settings could offer the options

  • force off (override room settings)
  • force on (override room settings)
  • default off
  • default on

and the room settings to complement it:

  • [disabled (greyed out): forced off/on by global settings (click link to go to global setting)]
  • default (off/on) where off/on represents the current global setting
  • off (override global default)
  • on (override global default)

the room settings should also offer these 3 distinct settings such that when e.g. you have default on and room on, then switch default off, you end up with default off and room on.

@MadLittleMods MadLittleMods changed the title URL previews cannot be turned off Override, inherit, and default global and room URL preview settings Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants