Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings with inverted values are being read incorrectly #17132

Open
turt2live opened this issue May 3, 2021 · 2 comments
Open

Settings with inverted values are being read incorrectly #17132

turt2live opened this issue May 3, 2021 · 2 comments
Labels
A-Room-Settings A-User-Settings O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression Z-Chronic Z-TravisR

Comments

@turt2live
Copy link
Member

Something is flipping null/undefined to true unsafely, and that makes certain levels of settings unusable.

As an example: showReadReceipts: false at the config level has no effect because the settings store thinks the value was set to true at the device level
@turt2live
Copy link
Member Author

Workaround is to use the inverted setting names in the config levels so the handlers read the correct values

@turt2live turt2live added P2 and removed P1 labels May 3, 2021
@psrpinto
Copy link
Contributor

psrpinto commented Oct 1, 2021

I'm not sure, but this might be fixed by matrix-org/matrix-react-sdk#6896

@t3chguy t3chguy added O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed P2 labels May 17, 2022
@t3chguy t3chguy mentioned this issue Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room-Settings A-User-Settings O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression Z-Chronic Z-TravisR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@psrpinto @turt2live @t3chguy