Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Resolve" emojis if they're valid after their trailing : #19178

Open
ShadowJonathan opened this issue Sep 26, 2021 · 4 comments
Open

"Resolve" emojis if they're valid after their trailing : #19178

ShadowJonathan opened this issue Sep 26, 2021 · 4 comments
Labels
A-Autocomplete A-Composer A-Emoji O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement Z-Papercuts Visible. Impactful. Predictable to action.

Comments

@ShadowJonathan
Copy link
Contributor

ShadowJonathan commented Sep 26, 2021

Your use case

What would you like to do?

If i've typed an emoji, and they're valid when "closing" them with a trailing :, resolve them according to the exact shortcode.

Why would you like to do it?

It's established behaviour in Discord, and it'd fix some weird behaviour in #19174

How would you like to achieve it?

When typing a :, check if all preceding non-whitespace characters (up until another :) are a valid shortcode, then resolve.

Note: not only if an emoji suggestion picker is present, discord behaviour is to convert (:eyes:) to (:eyes:) after the last :

Have you considered any alternatives?

No response

Additional context

Here's a video showcasing the behaviour i'd like;

emoji_typing_discord_complete-2021-09-26_12.05.54.mp4
@Palid
Copy link
Contributor

Palid commented Sep 30, 2021

@daniellekirkwood this enhancement looks good to me, but I need product acceptance. 😄

@ShadowJonathan
Copy link
Contributor Author

Also, for consistency, I'd like it if this auto-resolving also happens on paste, as discord also does that automatically.

@MadLittleMods
Copy link
Contributor

Related to #7256

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Oct 19, 2021

@Palid Product accepted... We should resolve the emoji shorthand if we are able to. For example :+1: should resolve automatically to 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Autocomplete A-Composer A-Emoji O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement Z-Papercuts Visible. Impactful. Predictable to action.
Projects
None yet
Development

No branches or pull requests

5 participants