Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalinks behave unreliably when target hidden by pre-join-UISI-hider #19230

Open
kittykat opened this issue Sep 30, 2021 · 4 comments
Open
Labels
A-E2EE A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Product More input needed from the Product team

Comments

@kittykat
Copy link
Contributor

kittykat commented Sep 30, 2021

Steps to reproduce

  1. In a room with multiple pinned messages, open the pinned panel
  2. Room settings need to have encryption enabled:

Screenshot from 2021-09-29 11-51-26

Screenshot from 2021-09-29 11-43-28

  1. Pick any pinned messages apart from the top one and click on "view message" repeatedly

What happened?

What did you expect?

To go to the same message every time the link is clicked

What happened?

Sometimes it takes me to the message, sometimes to another point in the timeline. I have screenshots and can share the room for reproducing the issue, but they both contain private content so please reach out to me.

Germain and I believe the issue is with encryption rather than pinned messages or timeline. This bug is probably exposed by #19231

S-Major because I can't access the room history at all. Occasional because it requires encryption to be enabled.

URL for webapp

develop.element.io

Have you submitted a rageshake?

No

@kittykat kittykat added T-Defect S-Critical Prevents work, causes data loss and/or has no workaround A-E2EE A-Timeline A-Message-Pinning O-Occasional Affects or can be seen by some users regularly or most users rarely labels Sep 30, 2021
@novocaine novocaine added S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed S-Critical Prevents work, causes data loss and/or has no workaround labels Sep 30, 2021
@novocaine
Copy link
Contributor

Can we please expand on why we think the problem is with encryption?

@t3chguy
Copy link
Member

t3chguy commented Oct 19, 2021

Cannot reproduce on a couple of fresh rooms, have asked oob for more details

@t3chguy
Copy link
Member

t3chguy commented Oct 19, 2021

I think this is unrelated to pinning really and is a side-effect of matrix-org/matrix-react-sdk#3881 hiding the backlog due to a gap in the timeline due to missing megolm sessions causing all sorts of confusion in the TimelinePanel.

One proposed solution to this is to replace matrix-org/matrix-react-sdk#3881 with an ELS-like thing for UISIs which collapses them, though this could have an effect like #11963 or #11604

@t3chguy t3chguy changed the title Clicking on same "view message" in pinned messages takes me to different messages Permalinks behave unreliably when target hidden by pre-join-UISI-hider Oct 19, 2021
@kittykat kittykat added the X-Needs-Product More input needed from the Product team label Oct 19, 2021
@richvdh
Copy link
Member

richvdh commented Apr 20, 2023

related: #22671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Product More input needed from the Product team
Projects
None yet
Development

No branches or pull requests

4 participants