Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registration: Network failure will show "Someone already has that username." #20725

Closed
jaller94 opened this issue Jan 24, 2022 · 3 comments
Closed

Registration: Network failure will show "Someone already has that username." #20725

jaller94 opened this issue Jan 24, 2022 · 3 comments
Assignees
@t3chguy
Labels
A-Registration good first issue Good for newcomers Help Wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@jaller94
Copy link
Contributor

Steps to reproduce

  1. https://app.element.io/#/register
  2. Disable your WiFi/network to simulate going offline.
  3. Type in a user name.

Outcome

What did you expect?

An error message about being offline or that the app was otherwise unable to check if the username is unavailable.

What happened instead?

The network request GET https://fosdem-attendees.ems.host/_matrix/client/r0/register/available?username=jaller94 had failed.

Element told me that the username is taken. As a non-experienced user I would assume this is the truth an pick a different username. This is frustrating, if it was just a short network issue.

Screenshot_2022-01-24_22-06-25

Operating system

Manjaro Linux

Browser information

Firefox Developer 97

URL for webapp

https://chat.fosdem.org

Application version

Element 1.9.9

Homeserver

attendees.fosdem.org

Will you send logs?

No
@germain-gg germain-gg added O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist good first issue Good for newcomers labels Jan 25, 2022
@t3chguy t3chguy self-assigned this Jan 25, 2022
@kittykat kittykat added the Help Wanted Extra attention is needed label Jan 31, 2022
@dbkr
Copy link
Member

dbkr commented Jan 31, 2022

If someone's looking to pick this up as a good first issue, this would be the registration code of react-sdk calling a matrix-js-sdk method to then call this REST API, and obviously the js-sdk API should distinguish failures from the username not being available.

@t3chguy
Copy link
Member

t3chguy commented Jan 31, 2022

err I already did this :'(

@t3chguy
Copy link
Member

t3chguy commented Jan 31, 2022

Fixed by matrix-org/matrix-react-sdk#7621

@t3chguy t3chguy closed this as completed Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Registration good first issue Good for newcomers Help Wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kittykat @germain-gg @dbkr @t3chguy @aaronraimist @jaller94