Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline jumps when switching rooms to timelines with potential URL previews #21933

Closed
turt2live opened this issue Apr 26, 2022 · 2 comments
Closed

Timeline jumps when switching rooms to timelines with potential URL previews #21933

turt2live opened this issue Apr 26, 2022 · 2 comments
Labels
T-Defect

Comments

@turt2live
Copy link
Member

Steps to reproduce

  1. Disable URL previews server-side, but not in the client
  2. Visit a room with lots of links (in my case, EMS Ops)
  3. Note the timeline jump

Outcome

What did you expect?

For the timeline not to jump immediately upon opening the room.

What happened instead?

The timeline jumped. It appears to be a gap roughly the height of the typing notification container, and goes away after the URL previews error out.

This appears to be a regression: we didn't previously reserve the space while the preview was loading, instead opting to pop-in the previews.

Operating system

Windows 10

Application version

0.0.1-nightly.2022042601

How did you install the app?

The Internet

Homeserver

t2l.io

Will you send logs?

No
@turt2live
Copy link
Member Author

at least I think this is related to URL previews - my timeline is bouncing around a lot

@t3chguy
Copy link
Member

t3chguy commented Apr 26, 2022

This is a symptom of #21930

@t3chguy t3chguy closed this as completed Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turt2live @t3chguy