Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify voice message bitrate #24103

Closed
Bleuzen opened this issue Dec 23, 2022 · 1 comment
Closed

Unify voice message bitrate #24103

Bleuzen opened this issue Dec 23, 2022 · 1 comment
Labels
A-Voice-Messages O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement

Comments

@Bleuzen
Copy link

Bleuzen commented Dec 23, 2022

Your use case

The opus bitrate of voice messages is different when comparing mobile to desktop client.

The mobile client uses a higher bitrate (35 kbps in my test, probably abr targetting ~ 32 kbps)
while the desktop client uses a lower bitrate (23 in my test, probably abr targetting ~ 24 kbps).

What would you like to do?

Increase the voice message bitrate of the desktop client (currently ~ 24 kbps) to match the one of the mobile client (~ 32 kbps).

Why would you like to do it?

1.) The current encoding settings are inconsistent (in a way it doesn't make sense)
2.) The current audio quality of voice messages is bad. This is more apparent on the desktop client since people more likely have better mics on their desktop setup compared to the tiny mics of their phones. Together with the fact that the desktop client uses this low bitrate, it just sounds bad. Increasing the bitrate should improve the audio quality.

How would you like to achieve it?

Increase the bitrate of the desktop client to match the one of the mobile client (~ 24 -> ~ 32 kbps).

32 kbps for opus voice messages is usually a good compromise for "okay" audio quality while keeping the file size small, so it is a good default value to use for both client types in my opinion.

Have you considered any alternatives?

Short term: no, I think just using ~ 32 kbps in all clients should do just fine.

Long term: just an idea, perhaps implement a setting to select the voice message bitrate. Not sure if this is overkill, should probably be discussed in another issue if there is enough interest.

Additional context

No response

@weeman1337 weeman1337 added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Voice-Messages O-Occasional Affects or can be seen by some users regularly or most users rarely labels Dec 27, 2022
@turt2live
Copy link
Member

As per the MSC (matrix-org/matrix-spec-proposals#3245), the mobile clients should be lowering their bitrate instead.

@turt2live turt2live closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Voice-Messages O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants