Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Composer" > "WYSIWYG" > "sends a message when you click send or press Enter" is flaky #24269

Closed
robintown opened this issue Jan 20, 2023 · 2 comments
Closed

"Composer" > "WYSIWYG" > "sends a message when you click send or press Enter" is flaky #24269

robintown opened this issue Jan 20, 2023 · 2 comments
Labels
A-Composer A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor A-Testing Testing, code coverage, etc. O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Defect Z-Flaky-Test A test is raising false alarms Z-Labs

Comments

@robintown
Copy link
Member

https://cloud.cypress.io/projects/ppvnzg/runs/8462/test-results/51558f28-d140-4a83-9723-78f1b2ca4779

Screenshot 2023-01-19 at 21-44-22 matrix-react-sdk
@robintown robintown added T-Defect A-Testing Testing, code coverage, etc. O-Uncommon Most users are unlikely to come across this or unexpected workflow Z-Flaky-Test A test is raising false alarms A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor A-Composer labels Jan 20, 2023
@florianduros
Copy link
Member

florianduros commented Jan 20, 2023 •
edited
Loading

Huch again, I though I had fixed it some days ago 😡

matrix-org/matrix-react-sdk#9948 Maybe this PR fixed it today. One of my idea is that we are typing after we press enter but we were clearing and focusing the composer after the async message ending.
So kind of racing issue, we are typing the second message and we clear the content of the first message at the same time.

Normally the fix from PR#9948 should fix it 🤞

@robintown
Copy link
Member Author

Thanks, then let's consider this fixed until proven otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Composer A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor A-Testing Testing, code coverage, etc. O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Defect Z-Flaky-Test A test is raising false alarms Z-Labs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@florianduros @robintown