Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room pill should always try to resolve room name and avatar #24705

Closed
weeman1337 opened this issue Mar 1, 2023 · 3 comments
Closed

Room pill should always try to resolve room name and avatar #24705

weeman1337 opened this issue Mar 1, 2023 · 3 comments
Labels
A-Pills O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement

Comments

@weeman1337
Copy link
Contributor

weeman1337 commented Mar 1, 2023 •
edited
Loading

Your use case

Part of element-hq/element-meta#1030

What would you like to do?

Currently room pills to look like this if a user didn't join the room yet:

image

Matrix.to for instance does display the room name and avatar:

image

Why would you like to do it?

Consistent user experience: Same room name and avatar before and after joining the room.

How would you like to achieve it?

Try to query room data when adding the pill.

Have you considered any alternatives?

No response

Additional context

No response
@weeman1337 weeman1337 added S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement O-Occasional Affects or can be seen by some users regularly or most users rarely labels Mar 1, 2023
@weeman1337 weeman1337 mentioned this issue Mar 1, 2023
Closed
12 tasks
@t3chguy
Copy link
Member

t3chguy commented Mar 1, 2023

Matrix.to for instance does display the room name and avatar:

It grabs huge pages of /publicRooms API until it finds the right room, this isn't exactly a great thing to copy :P

@giomfo
Copy link
Member

giomfo commented Mar 9, 2023

@weeman1337 FYI when the room/space details are not available, we will display the following pill:
image

@giomfo
Copy link
Member

giomfo commented Mar 16, 2023

We changed our mind, we won't retrieve room details by default. We will use the local data

@giomfo giomfo closed this as completed Mar 16, 2023
@giomfo giomfo closed this as not planned Won't fix, can't repro, duplicate, stale Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Pills O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@t3chguy @weeman1337 @giomfo