Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to-device messages can be processed out-of-order, causing dropped keys and decryption errors #25723

Closed
richvdh opened this issue Jul 5, 2023 · 3 comments
Closed

to-device messages can be processed out-of-order, causing dropped keys and decryption errors #25723

richvdh opened this issue Jul 5, 2023 · 3 comments
Labels
A-E2EE O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Awaiting-Element-R Issues in code which will be replaced by the port of Element's crypto layer to Rust

Comments

@richvdh
Copy link
Member

richvdh commented Jul 5, 2023

Events - including to-device messages - received over /sync are decrypted in parallel. libolm can handle some reordering of to-device messages: it remembers up to 40 "skipped keys", but in extreme cases, this parallelisation can cause reordering so bad that message keys are forgotten.
@richvdh richvdh added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-E2EE O-Uncommon Most users are unlikely to come across this or unexpected workflow Z-Awaiting-Element-R Issues in code which will be replaced by the port of Element's crypto layer to Rust labels Jul 5, 2023
@richvdh
Copy link
Member Author

richvdh commented Jul 5, 2023

related to element-hq/element-meta#762

This was referenced Jul 5, 2023
Closed
Open
@richvdh richvdh mentioned this issue Oct 5, 2023
Open
75 tasks
@BillCarsonFr
Copy link
Member

Adding a test to the complement crypto test list

@andybalaam andybalaam mentioned this issue Mar 22, 2024
Closed
@kegsay
Copy link
Contributor

kegsay commented Jun 13, 2024

Test written and passing, closing.

@kegsay kegsay closed this as completed Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Awaiting-Element-R Issues in code which will be replaced by the port of Element's crypto layer to Rust
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@richvdh @kegsay @BillCarsonFr