Element Web R can't send encrypted messages on dendrite/conduit #26566

ninchuka · 2023-11-13T16:29:48Z

Steps to reproduce

Where are you starting? What can you see?
sending encrypted message with rust SDK on dendrite
What do you click?
sending message in encrypted room
More steps…

Outcome

What did you expect?

for message to be sent

What happened instead?

ele web says
Some of your messages have not been sent
You can select all or individual messages to retry or delete

while in the console I see, I have asked a user on another dendrite HS to double check its not a issue with the one I'm on and they saw it as well element web says Session key: <not supported> as well in the security & privacy area of settings

POST https://matrix.pain.agency/_matrix/client/v3/keys/upload 400 (Bad Request)
(anonymous) @ instrument.js:155
fetch @ fetch.ts:60
requestOtherUrl @ fetch.ts:304
request @ fetch.ts:241
authedRequest @ fetch.ts:159
rawJsonRequest @ OutgoingRequestProcessor.ts:198
makeOutgoingRequest @ OutgoingRequestProcessor.ts:74
processOutgoingRequests @ OutgoingRequestsManager.ts:133
await in processOutgoingRequests (async)
outgoingRequestLoop @ OutgoingRequestsManager.ts:109
doProcessOutgoingRequests @ OutgoingRequestsManager.ts:85
ensureEncryptionSession @ RoomEncryptor.ts:141
await in ensureEncryptionSession (async)
encryptEvent @ RoomEncryptor.ts:207
encryptEvent @ rust-crypto.ts:284
encryptEventIfNeeded @ client.ts:4740
(anonymous) @ client.ts:4637
Promise.then (async)
encryptAndSendEvent @ client.ts:4636
resendEvent @ client.ts:4315
resend @ Resend.ts:48
(anonymous) @ Resend.ts:31
resendUnsentEvents @ Resend.ts:30
(anonymous) @ RoomStatusBar.tsx:137
Rb @ react-dom.production.min.js:52
Xb @ react-dom.production.min.js:52
Yb @ react-dom.production.min.js:53
Ze @ react-dom.production.min.js:100
se @ react-dom.production.min.js:101
(anonymous) @ react-dom.production.min.js:113
Jb @ react-dom.production.min.js:292
Nb @ react-dom.production.min.js:50
jd @ react-dom.production.min.js:105
yc @ react-dom.production.min.js:75
hd @ react-dom.production.min.js:74
exports.unstable_runWithPriority @ scheduler.production.min.js:18
gg @ react-dom.production.min.js:122
Hb @ react-dom.production.min.js:292
gd @ react-dom.production.min.js:73
rageshake.ts:74 Failed to process outgoing request 0: Unknown error code: MatrixError: [400] Unknown message (https://matrix.pain.agency/_matrix/client/v3/keys/upload)
consoleObj.<computed> @ rageshake.ts:74
(anonymous) @ instrument.js:125
(anonymous) @ logger.ts:94
processOutgoingRequests @ OutgoingRequestsManager.ts:137
await in processOutgoingRequests (async)
outgoingRequestLoop @ OutgoingRequestsManager.ts:109
doProcessOutgoingRequests @ OutgoingRequestsManager.ts:85
ensureEncryptionSession @ RoomEncryptor.ts:141
await in ensureEncryptionSession (async)
encryptEvent @ RoomEncryptor.ts:207
encryptEvent @ rust-crypto.ts:284
encryptEventIfNeeded @ client.ts:4740
(anonymous) @ client.ts:4637
Promise.then (async)
encryptAndSendEvent @ client.ts:4636
resendEvent @ client.ts:4315
resend @ Resend.ts:48
(anonymous) @ Resend.ts:31
resendUnsentEvents @ Resend.ts:30
(anonymous) @ RoomStatusBar.tsx:137
Rb @ react-dom.production.min.js:52
Xb @ react-dom.production.min.js:52
Yb @ react-dom.production.min.js:53
Ze @ react-dom.production.min.js:100
se @ react-dom.production.min.js:101
(anonymous) @ react-dom.production.min.js:113
Jb @ react-dom.production.min.js:292
Nb @ react-dom.production.min.js:50
jd @ react-dom.production.min.js:105
yc @ react-dom.production.min.js:75
hd @ react-dom.production.min.js:74
exports.unstable_runWithPriority @ scheduler.production.min.js:18
gg @ react-dom.production.min.js:122
Hb @ react-dom.production.min.js:292
gd @ react-dom.production.min.js:73
instrument.js:155 
        
        
       POST https://matrix.pain.agency/_matrix/client/v3/keys/claim 400 (Bad Request)
(anonymous) @ instrument.js:155
fetch @ fetch.ts:60
requestOtherUrl @ fetch.ts:304
request @ fetch.ts:241
authedRequest @ fetch.ts:159
rawJsonRequest @ OutgoingRequestProcessor.ts:198
makeOutgoingRequest @ OutgoingRequestProcessor.ts:78
ensureSessionsForUsersInner @ KeyClaimManager.ts:76
await in ensureSessionsForUsersInner (async)
(anonymous) @ KeyClaimManager.ts:64
Promise.then (async)
ensureSessionsForUsers @ KeyClaimManager.ts:64
ensureEncryptionSession @ RoomEncryptor.ts:149
await in ensureEncryptionSession (async)
encryptEvent @ RoomEncryptor.ts:207
encryptEvent @ rust-crypto.ts:284
encryptEventIfNeeded @ client.ts:4740
(anonymous) @ client.ts:4637
Promise.then (async)
encryptAndSendEvent @ client.ts:4636
resendEvent @ client.ts:4315
resend @ Resend.ts:48
(anonymous) @ Resend.ts:31
resendUnsentEvents @ Resend.ts:30
(anonymous) @ RoomStatusBar.tsx:137
Rb @ react-dom.production.min.js:52
Xb @ react-dom.production.min.js:52
Yb @ react-dom.production.min.js:53
Ze @ react-dom.production.min.js:100
se @ react-dom.production.min.js:101
(anonymous) @ react-dom.production.min.js:113
Jb @ react-dom.production.min.js:292
Nb @ react-dom.production.min.js:50
jd @ react-dom.production.min.js:105
yc @ react-dom.production.min.js:75
hd @ react-dom.production.min.js:74
exports.unstable_runWithPriority @ scheduler.production.min.js:18
gg @ react-dom.production.min.js:122
Hb @ react-dom.production.min.js:292
gd @ react-dom.production.min.js:73
rageshake.ts:74 Error sending event M_BAD_JSON: MatrixError: [400] The request body could not be decoded into valid JSON. json: cannot unmarshal object into Go struct field claimKeysRequest.timeout of type int (https://matrix.pain.agency/_matrix/client/v3/keys/claim)
    at parseErrorResponse (https://develop.element.io/bundles/c95983ad3677cd7691c4/bundle.js:118899:12)
    at MatrixHttpApi.requestOtherUrl (https://develop.element.io/bundles/c95983ad3677cd7691c4/bundle.js:234520:86)
    at async MatrixHttpApi.authedRequest (https://develop.element.io/bundles/c95983ad3677cd7691c4/bundle.js:234361:24)
    at async OutgoingRequestProcessor.rawJsonRequest (https://develop.element.io/bundles/c95983ad3677cd7691c4/34.js:1973:12)
    at async OutgoingRequestProcessor.makeOutgoingRequest (https://develop.element.io/bundles/c95983ad3677cd7691c4/34.js:1891:14)
    at async KeyClaimManager.ensureSessionsForUsersInner (https://develop.element.io/bundles/c95983ad3677cd7691c4/34.js:2053:7)
    at async RoomEncryptor.ensureEncryptionSession (https://develop.element.io/bundles/c95983ad3677cd7691c4/34.js:1746:5)
    at async RoomEncryptor.encryptEvent (https://develop.element.io/bundles/c95983ad3677cd7691c4/34.js:1795:5)
    at async RustCrypto.encryptEvent (https://develop.element.io/bundles/c95983ad3677cd7691c4/34.js:364:5)
    at async Promise.all (index 0)

Operating system

Fedora 38

Browser information

Chrome 119.0.6045.123

URL for webapp

https://develop.element.io/

Application version

Element version: 781a067-react-6ee8349f7ce6-js-7de9b23e5993 Crypto version: Rust SDK 0.6.0 (17d4f2f), Vodozemac 0.5.0

Homeserver

pain.agency Dendrite 0.13.4+317b101

Will you send logs?

Yes

The text was updated successfully, but these errors were encountered:

ninchuka · 2023-11-13T17:14:11Z

it also doesnt work on conduit either, getting a friend to send a rageshake of it failing on conduit as well

jjj333-p · 2023-11-13T22:10:45Z

Adding some context as the sysadmin of pain.agency, i see the following error a lot in my logs (when dendrite isn't shitting itself about something else, as it does) which appears to be related to this bug

Nov 13 21:49:56 snapshot-115842185-debian-2gb-hil-1 dendrite[387921]: time="2023-11-13T21:49:56.598560396Z" level=error msg="Failed to upload one or more keys" key_errors="map[@j:pain.agency:map[0ZZeMt1g:user_id or device_id mismatch: users: - @j:pain.agency, devices: - 0ZZeMt1g]]" req.id=JD2decX9Cwh8 req.method=POST req.path=/_matrix/client/v3/keys/upload user_id="@j:pain.agency"

( @j:pain.agency is @ninja85a )

Unsure if this is a bug on the dendrite side causing it to fail or if something is awry in how element is handling it

S7evinK · 2023-11-15T08:37:36Z

If I didn't do anything wrong, this seems to be an issue in ruma?

/keys/upload contains device_keys: null (which should be absent as per the spec).
/keys/claim has timeout":{"nanos":0,"secs":10} in the request body, which should be a plain integer. (this is where e.g. Dendrite falls over with json: cannot unmarshal object into Go struct field claimKeysRequest.timeout of type int

t3chguy · 2023-11-15T22:22:36Z

The request body is built by the Rust SDK

This looks like matrix-org/matrix-rust-sdk#801 which is claimed to be fixed - wonder if it regressed

cc @richvdh

richvdh · 2023-11-16T13:04:40Z

This looks like matrix-org/matrix-rust-sdk#801 which is claimed to be fixed - wonder if it regressed

Looks like it was fixed in the nodejs bindings but not the wasm bindings. Arguably it's silly that it is being done in the bindings at all.

Have filed matrix-org/matrix-rust-sdk-crypto-wasm#56 and matrix-org/matrix-rust-sdk-crypto-wasm#57 to track this on the Rust side.

richvdh · 2023-11-24T10:50:46Z

We believe we can make a quick fix for this in the wasm bindings, and will do so for Element-R release.

uhoreg · 2024-01-23T04:48:41Z

This is fixed in matrix-sdk-crypto-wasm v4.0.0, which matrix-js-sdk now depends on, so it should be fixed in the next release of Element R

richvdh · 2024-01-23T11:21:40Z

This is fixed in matrix-sdk-crypto-wasm v4.0.0

I don't think that's right. matrix-sdk-crypto-wasm v4.0.0 does not include matrix-org/matrix-rust-sdk-crypto-wasm#72.

richvdh · 2024-01-23T11:22:27Z

[it would be good to have some tests at the js-sdk level to prove this one way or another.]

richvdh · 2024-01-23T11:28:45Z

matrix-sdk-crypto-wasm v4.0.1 does include the fix, so this will probably be fixed by matrix-org/matrix-js-sdk#4025, but given a test should be trivial: please can we do so?

ninchuka added the T-Defect label Nov 13, 2023

ninchuka changed the title ~~ele web with rusk SDK cant send encrypted messages on dendrite HS~~ ele web with rusk SDK cant send encrypted messages on dendrite/conduit Nov 15, 2023

t3chguy added Z-Upstream Z-Spec-Compliance An area where Element doesn't correctly implement the spec Team: Crypto A-Element-R Issues affecting the port of Element's crypto layer to Rust Z-Element-R-Blocker A blocker for enabling Element R by default labels Nov 15, 2023

github-actions bot added the Z-Labs label Nov 15, 2023

t3chguy added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Nov 16, 2023

richvdh changed the title ~~ele web with rusk SDK cant send encrypted messages on dendrite/conduit~~ Element Web R ele web with rusk SDK cant send encrypted messages on dendrite/conduit Nov 16, 2023

richvdh changed the title ~~Element Web R ele web with rusk SDK cant send encrypted messages on dendrite/conduit~~ Element Web R can't send encrypted messages on dendrite/conduit Nov 16, 2023

uhoreg self-assigned this Dec 12, 2023

uhoreg mentioned this issue Dec 14, 2023

Correctly encode Duration and optional fields matrix-org/matrix-rust-sdk-crypto-wasm#72

Merged

uhoreg closed this as completed Jan 23, 2024

richvdh reopened this Jan 23, 2024

uhoreg mentioned this issue Jan 25, 2024

Element R: Add test that requests are encoded properly matrix-org/matrix-js-sdk#4033

Merged

3 tasks

uhoreg closed this as completed in matrix-org/matrix-js-sdk#4033 Jan 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Element Web R can't send encrypted messages on dendrite/conduit #26566

Element Web R can't send encrypted messages on dendrite/conduit #26566

ninchuka commented Nov 13, 2023 •

edited by richvdh

Loading

ninchuka commented Nov 13, 2023

jjj333-p commented Nov 13, 2023

S7evinK commented Nov 15, 2023

t3chguy commented Nov 15, 2023

richvdh commented Nov 16, 2023

richvdh commented Nov 24, 2023

uhoreg commented Jan 23, 2024

richvdh commented Jan 23, 2024 •

edited

Loading

richvdh commented Jan 23, 2024

richvdh commented Jan 23, 2024

Element Web R can't send encrypted messages on dendrite/conduit #26566

Element Web R can't send encrypted messages on dendrite/conduit #26566

Comments

ninchuka commented Nov 13, 2023 • edited by richvdh Loading

Steps to reproduce

Outcome

What did you expect?

What happened instead?

Operating system

Browser information

URL for webapp

Application version

Homeserver

Will you send logs?

ninchuka commented Nov 13, 2023

jjj333-p commented Nov 13, 2023

S7evinK commented Nov 15, 2023

t3chguy commented Nov 15, 2023

richvdh commented Nov 16, 2023

richvdh commented Nov 24, 2023

uhoreg commented Jan 23, 2024

richvdh commented Jan 23, 2024 • edited Loading

richvdh commented Jan 23, 2024

richvdh commented Jan 23, 2024

ninchuka commented Nov 13, 2023 •

edited by richvdh

Loading

richvdh commented Jan 23, 2024 •

edited

Loading