Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element-R / Manually trigger the experimental Rust Migration labs flag will wrongly trigger the Missing Session Data Dialog #26970

Closed
BillCarsonFr opened this issue Feb 5, 2024 · 1 comment · Fixed by matrix-org/matrix-react-sdk#12225
Closed

Element-R / Manually trigger the experimental Rust Migration labs flag will wrongly trigger the Missing Session Data Dialog #26970

BillCarsonFr opened this issue Feb 5, 2024 · 1 comment · Fixed by matrix-org/matrix-react-sdk#12225
Assignees
@BillCarsonFr
Labels
A-DevTools /devtools, show hidden events, etc. A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Team: Crypto Z-Labs

Comments

@BillCarsonFr
Copy link
Member

Step to reproduce

  • Type /devtools in the composer, then scroll down to enable dev mode
  • Go to settings > Labs
  • Enable Rust cryptography implementation if your deployement allows

Actual

image

Expected

Should migrate

What happens

See rageshake https://github.com/matrix-org/element-web-rageshakes/issues/24175

2024-02-05T09:14:21.377Z D StorageManager: Local storage supported? true
2024-02-05T09:14:21.377Z D StorageManager: IndexedDB supported? true
2024-02-05T09:14:21.377Z D StorageManager: Local storage contains data? true
2024-02-05T09:14:21.377Z D StorageManager: Crypto initialised? true
2024-02-05T09:14:21.378Z D StorageManager: Sync store using IndexedDB contains data? true
2024-02-05T09:14:21.380Z D StorageManager: Crypto store using IndexedDB contains data? false

The StorageManager thinks that you are already on rust, but the migration hasn't yet started, so it's checking the wrong store.

This doesn't happen if the migration is triggered by the rollout, as the StorageManage check will be done before feature_rust_crypto is true at the device level.
@BillCarsonFr BillCarsonFr self-assigned this Feb 5, 2024
@BillCarsonFr BillCarsonFr mentioned this issue Feb 5, 2024
Merged
3 tasks
@florianduros florianduros added T-Defect A-DevTools /devtools, show hidden events, etc. Team: Crypto A-Element-R Issues affecting the port of Element's crypto layer to Rust labels Feb 5, 2024
@github-actions github-actions bot added the Z-Labs label Feb 5, 2024
@florianduros florianduros added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed Z-Labs labels Feb 5, 2024
@github-actions github-actions bot added the Z-Labs label Feb 5, 2024
@richvdh
Copy link
Member

richvdh commented Feb 5, 2024

This was apparently introduced by matrix-org/matrix-react-sdk#12206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillCarsonFr BillCarsonFr

Labels
A-DevTools /devtools, show hidden events, etc. A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Team: Crypto Z-Labs
Projects
None yet
Milestone
No milestone
3 participants
@richvdh @florianduros @BillCarsonFr