Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reply previews are no longer limited to 2 lines #27928

Closed
robintown opened this issue Aug 16, 2024 · 1 comment · Fixed by matrix-org/matrix-react-sdk#12929
Closed

Reply previews are no longer limited to 2 lines #27928

robintown opened this issue Aug 16, 2024 · 1 comment · Fixed by matrix-org/matrix-react-sdk#12929
Assignees
@florianduros
Labels
A-Replies reply A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@robintown
Copy link
Member

Steps to reproduce

  1. Find a message that has more than 2 lines of text
  2. Reply to said message

Outcome

What did you expect?

The reply preview should be limited to show only the first 2 lines of text by default. (This is why the "expand quotes" button exists.)

What happened instead?

I see the entire message contents in the reply preview:

Screenshot 2024-08-16 at 11-41-42 Element 3 Test room

Operating system

NixOS unstable

Browser information

Firefox 127.0.2

URL for webapp

develop.element.io

Application version

Element version: 43fa2e5-react-6f3dc3069318-js-d6080398dbf5 Crypto version: Rust SDK 0.7.1 (c8c9d15), Vodozemac 0.6.0

Homeserver

Not relevant

Will you send logs?

No
@robintown robintown added T-Defect X-Regression S-Minor Impairs non-critical functionality or suitable workarounds exist A-Timeline A-Replies reply O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Aug 16, 2024
@dbkr dbkr added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Aug 16, 2024
@florianduros florianduros self-assigned this Aug 26, 2024
@florianduros
Copy link
Member

Regression due to matrix-org/matrix-react-sdk#12837

@florianduros florianduros mentioned this issue Aug 26, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florianduros florianduros

Labels
A-Replies reply A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix reply message truncation on 2 lines matrix-org/matrix-react-sdk
3 participants
@dbkr @florianduros @robintown