Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the icons with Google Material Design Icons #3372

Closed
ishitatsuyuki opened this issue Mar 6, 2017 · 2 comments
Closed

Replace the icons with Google Material Design Icons #3372

ishitatsuyuki opened this issue Mar 6, 2017 · 2 comments

Comments

@ishitatsuyuki
Copy link

tldr; Yes, your thin design is wrong.

The current icon has 1px width which hurts your eyes, and some of them looks odd (e.g. notifications bell).

Reference: Material Design Guidelines recommends 2dp stroke + round corner.

Why just not replace them with the industry standard MD icons?

  • The Google MD icons library probably has all the icon we use, in a more beautiful version.
  • It's available as Apache-2.0.
  • It's easy to add, just a npm package. Its size is probably more optimized than ours.
@ara4n
Copy link
Member

ara4n commented Mar 6, 2017

your opinion of the icons is subjective; please feel free to contribute a theme with whatever icons you happen to personally like the most.

@ara4n ara4n closed this as completed Mar 6, 2017
@tessgadwa
Copy link

@ara4n I have some issues with Google Material Design; it is a complete set of specifications but I don't feel it is the be-all-and-end-all. I have been thinking about contributing a Riot theme myself, to address some of the issues I have observed regarding the visibility of key features, for instance encryption labels.

I do have concerns about the proliferation of themes -- 1) Many naive users are overwhelmed and confused by choices, not empowered by them. 2) It diverts effort from making the core/default UX experience more seamless and awesome. 3) As new features and icons are added it will be more difficult for ad hoc authors authors to keep up with them and many themes will break.

I think the way that Trello handles theme choice, and also its UX for multi-platform integrations, is a great model. Note that they have a theme option specifically designed for low-vision, color-blind individuals.

@tessgadwa tessgadwa mentioned this issue Mar 6, 2017
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants