Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'delete' button in Room list in RightPanel needs to be themed and fixed #5347

Closed
ara4n opened this issue Oct 19, 2017 · 2 comments · Fixed by matrix-org/matrix-react-sdk#1540
Closed

'delete' button in Room list in RightPanel needs to be themed and fixed #5347

ara4n opened this issue Oct 19, 2017 · 2 comments · Fixed by matrix-org/matrix-react-sdk#1540
Assignees
@lukebarnard1
Labels
A-Spaces Spaces, groups, communities P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Release-Blocker

Comments

@ara4n
Copy link
Member

ara4n commented Oct 19, 2017

atm it's the wrong X and not themed so it's invisible on dark theme.
@lampholder lampholder added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround P1 A-Spaces Spaces, groups, communities ui/ux X-Release-Blocker labels Oct 20, 2017
@lukebarnard1 lukebarnard1 reopened this Oct 25, 2017
@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Oct 25, 2017 •
edited
Loading

@ara4n which icon is the right X?

@ara4n
Copy link
Member Author

ara4n commented Oct 26, 2017

cancel.svg or cancel-white.svg depending on the theme darkness. cancel-small is for deleting aliases & things in UserSettings.

@lukebarnard1 lukebarnard1 self-assigned this Oct 26, 2017
@lukebarnard1 lukebarnard1 mentioned this issue Oct 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebarnard1 lukebarnard1

Labels
A-Spaces Spaces, groups, communities P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use correct icon for group room deletion and make themeable matrix-org/matrix-react-sdk
3 participants
@ara4n @lampholder @lukebarnard1