Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested rich replies are an endless ping fest. #5968

Closed
turt2live opened this issue Jan 11, 2018 · 2 comments
Closed

Nested rich replies are an endless ping fest. #5968

turt2live opened this issue Jan 11, 2018 · 2 comments
Labels
A-Notifications A-Replies reply P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@turt2live
Copy link
Member

Description

Decided to test this in offtopic and we ended up with a 3-level nested reply that was still pining richvdh.

Steps to reproduce

  • Send a message with a ping to someone
  • Reply to it
  • Reply to the reply
  • Reply to the replied reply
  • and so on

It should probably not ping unless you are in the immediate reply?

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 63
  • OS: Windows 10
  • URL: riot.im/develop
@turt2live turt2live mentioned this issue Jan 11, 2018
Closed
@t3chguy
Copy link
Member

t3chguy commented Jan 13, 2018

This will be caused by the imperfect plaintext representation, so related to #5974

@lampholder lampholder added T-Defect ui/ux P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Notifications A-Replies reply labels Jan 16, 2018
@t3chguy t3chguy mentioned this issue Jan 16, 2018
Closed
@t3chguy t3chguy mentioned this issue Feb 10, 2018
Merged
@t3chguy
Copy link
Member

t3chguy commented May 4, 2018

Fixed by merged PR

@t3chguy t3chguy closed this as completed May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Notifications A-Replies reply P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turt2live @lampholder @t3chguy