Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting current device disconnects but the settings modal remains visible #9523

Closed
yzaroui opened this issue Apr 18, 2019 · 4 comments
Closed

Comments

@yzaroui
Copy link

yzaroui commented Apr 18, 2019

Description

When you delete your current device, you are disconnected and "routed" to the login UI but the settings modal remains visible and hides the login form.

Steps to reproduce

  • Open user settings
  • Select the Security & Privacy tab
  • Select your current device (bold line)
  • Click on Delete Device button

The user is disconnected and the login form is added behind the settings modal that stays visible.

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 73.0.3683.103, Firefox 65.0.1
  • OS: macOS,
  • URL: riot.im/app 1.0.7
@jryans
Copy link
Collaborator

jryans commented Apr 18, 2019

Thanks for reporting! I am sort of curious why we allow you to delete the current device at all...

What was your use case for deleting the current device? Is that really what you wanted to do?

@jryans jryans added the defect label Apr 18, 2019
@yzaroui
Copy link
Author

yzaroui commented Apr 18, 2019

It has the same behavior if let say I am on the settings on firefox, and from chrome I delete my firefox device. I get disconnected on firefox while the settings are still visible.

@lampholder
Copy link
Member

fwiw when I was thinking of how this UX could be improved (#8319) I proposed that we remove the ability for you to delete your current device from your own device list.

@robintown
Copy link
Member

The checkbox to delete your own device has been replaced with a more normal 'Sign out' button that does what you'd expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants