Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop NPN support #280

Closed
florimondmanca opened this issue Aug 26, 2019 · 2 comments · Fixed by #314
Closed

Drop NPN support #280

florimondmanca opened this issue Aug 26, 2019 · 2 comments · Fixed by #314
Labels
good first issue Good for newcomers http/2 Issues and PRs related to HTTP/2 tls+pki Issues and PRs related to TLS and PKI

Comments

@florimondmanca
Copy link
Member

florimondmanca commented Aug 26, 2019 •
edited
Loading

@pgjones suggested in #276 (comment) to stop using NPN to get the HTTP protocol in .get_http_version() on concurrency backends, and switch to ALPN-only.

(Technical notes of mine: NPN (Next Protocol Negociation) is a TLS extension that was added as part of SPDY a Google protocol whose spec eventually got merged into the HTTP/2 standard. Google announced this in 2016 in Hello HTTP/2, good bye SPDY, and ALPN now replaces NPN.)

I did a bit of research, and NPN removal does seem to have been on its way across the interwebs:

Anyone more experienced than me on HTTP protocols negociation got any thoughts on this?
@florimondmanca florimondmanca changed the title Remove NPN verification in get_http_version() Drop NPN support Aug 26, 2019
@florimondmanca florimondmanca mentioned this issue Aug 26, 2019
Merged
@florimondmanca florimondmanca added help wanted Extra attention is needed http/2 Issues and PRs related to HTTP/2 labels Aug 26, 2019
@sethmlarson
Copy link
Contributor

You can add macOS to the list as well. The new Network module only supports ALPN.

@tomchristie
Copy link
Member

Fair enough, that sounds like a nice little improvement.

@florimondmanca florimondmanca added good first issue Good for newcomers and removed help wanted Extra attention is needed labels Aug 27, 2019
@sethmlarson sethmlarson added the tls+pki Issues and PRs related to TLS and PKI label Aug 28, 2019
@dobrovolsky dobrovolsky mentioned this issue Sep 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers http/2 Issues and PRs related to HTTP/2 tls+pki Issues and PRs related to TLS and PKI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop NPN support dobrovolsky/httpx
3 participants
@tomchristie @florimondmanca @sethmlarson