Add macOS to the pipeline #1170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe #494 is because of the path name size? 🤔 |
Kludex
commented
Aug 22, 2021
| config = Config( | ||
| app=asgi_app, uds=uds_file.as_posix(), reload=reload, workers=workers | ||
| app=asgi_app, uds=uds_file.as_posix(), reload=reload, workers=workers, loop=loop |
There was a problem hiding this comment.
I'm not able to reproduce #494.
|
would be cool to add this to the pipeline but I dont get where you're at with this @Kludex ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @euri10 's recommendation on #1132 (comment), I also think we should add macOS to the pipeline.
The path we use to bind to the socket is 127 bytes length. AF_UNIX has only 108 bytes allocated for it, so we keep receiving
OSError: AF_UNIX path too long.The way I solved it is using theDoesn't work on Windows.--basetempparameter onpytest. You can check more about it on the docs and on this issue.I've used tmp_path_factory instead.