Fixed makeUnPushable/unDroppable bug #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and added a loading screen/overlay while waiting for view to mount
jasondkiesling
requested changes
Jun 13, 2019
src/components/Header.js
Outdated
| @@ -180,6 +182,10 @@ class Header extends Component { | |||
| if (this.state.lastMsgTime !== this.props.message.time && this.props.message.text !== "") { | |||
| this.setState({ snackOpen: true, lastMsgTime: this.props.message.time }); | |||
| } | |||
| if(shouldRender) { | |||
There was a problem hiding this comment.
This doesn't look like it is really the way that we should be doing this. Something is weird.
|
I removed the loading screen because I couldn't get it to work through the components state, so I want to take more time to figure out a fix for that. Also any white space that was added/remove in this commit was due to the auto formatter |
|
The way that render is working now isn't really the way we should be doing it. More investigation is needed. If you want to remove that part for now we can push the makeUnDrop/Pushable part. |
|
You also have some merge conflicts that need to be resolved. |
jSwanson99
changed the title
jasondkiesling
approved these changes
Jun 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and added a loading screen/overlay while waiting for view to mount