Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for the new LiteSPI core #447

Merged
merged 4 commits into from
Apr 1, 2020

Conversation

piotr-binkowski
Copy link
Collaborator

This PR adds support for LiteSPI to litex_sim and to NeTV2 target

@enjoy-digital
Copy link
Owner

Thanks, is it working in simulation and on hardware?

@piotr-binkowski
Copy link
Collaborator Author

Yes, it works both in simulation and on hardware but after litex-hub/litespi#9 gets merged the NeTV2 target will need an update to still work correctly.

Copy link
Owner

@enjoy-digital enjoy-digital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good if it's already working in simulation and on hardware. I did a few comments on minor things we should probably change. Can you look at that and update the PR? Once done we could merge.

litex/boards/targets/netv2.py Outdated Show resolved Hide resolved
litex/boards/targets/netv2.py Outdated Show resolved Hide resolved
litex/tools/litex_sim.py Outdated Show resolved Hide resolved
litex/tools/litex_sim.py Outdated Show resolved Hide resolved
litex/tools/litex_sim.py Outdated Show resolved Hide resolved
@piotr-binkowski
Copy link
Collaborator Author

@enjoy-digital I've updated the code with changes you mentioned

@enjoy-digital enjoy-digital merged commit 27f0085 into enjoy-digital:master Apr 1, 2020
@enjoy-digital
Copy link
Owner

Thanks! That's merged.

@piotr-binkowski piotr-binkowski deleted the spi-xip branch April 2, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants