diff --git a/src/main/resources/assets/admin/common/js/security/PrincipalLoader.ts b/src/main/resources/assets/admin/common/js/security/PrincipalLoader.ts index db6e5ec42..59d191dad 100644 --- a/src/main/resources/assets/admin/common/js/security/PrincipalLoader.ts +++ b/src/main/resources/assets/admin/common/js/security/PrincipalLoader.ts @@ -6,6 +6,7 @@ import {IdProviderKey} from './IdProviderKey'; import {Principal} from './Principal'; import {PrincipalKey} from './PrincipalKey'; import {GetPrincipalsByKeysRequest} from './GetPrincipalsByKeysRequest'; +import {BaseLoader} from '../util/loader/BaseLoader'; export class PrincipalLoader extends PostLoader { @@ -65,8 +66,8 @@ export class PrincipalLoader return this.getRequest().isPartiallyLoaded(); } - setUsePreData(bool: boolean): PrincipalLoader { - super.setUsePreData(bool); + setUseDataPreLoad(bool: boolean): PrincipalLoader { + super.setUseDataPreLoad(bool); return this; } diff --git a/src/main/resources/assets/admin/common/js/ui/selector/combobox/BaseSelectedOptionsView.ts b/src/main/resources/assets/admin/common/js/ui/selector/combobox/BaseSelectedOptionsView.ts index c25aa6b77..717f3a7e0 100644 --- a/src/main/resources/assets/admin/common/js/ui/selector/combobox/BaseSelectedOptionsView.ts +++ b/src/main/resources/assets/admin/common/js/ui/selector/combobox/BaseSelectedOptionsView.ts @@ -10,6 +10,7 @@ import {SelectedOptionEvent} from './SelectedOptionEvent'; import {BaseSelectedOptionView, BaseSelectedOptionViewBuilder} from './BaseSelectedOptionView'; import {assertNotNull} from '../../../util/Assert'; import {PEl} from '../../../dom/PEl'; +import {i18n} from '../../../util/Messages'; export class BaseSelectedOptionsView extends DivEl @@ -72,8 +73,8 @@ export class BaseSelectedOptionsView return new SelectedOption(new BaseSelectedOptionView(builder), this.count()); } - // Will mark all options as selected, but if there are more options than {MAX_TO_APPEND} - // it'll append only {MAX_TO_APPEND} of them to the view in order to improve performance. + /* Will mark all options as selected, but if there are more options than {MAX_TO_APPEND} + it'll append only {MAX_TO_APPEND} of them to the view in order to improve performance. */ addOptions(options: Option[], silent: boolean = false, keyCode: number): boolean { let result: boolean; @@ -86,7 +87,7 @@ export class BaseSelectedOptionsView const selectedOptions: SelectedOption[] = options.map((option, index) => { const selectedOption = this.createSelectedOption(option); - if(index <= BaseSelectedOptionsView.MAX_TO_APPEND) { + if (index <= BaseSelectedOptionsView.MAX_TO_APPEND) { const optionView = selectedOption.getOptionView(); optionView.onRemoveClicked(() => this.removeOption(option)); this.appendChild(optionView); @@ -97,7 +98,7 @@ export class BaseSelectedOptionsView this.list = selectedOptions; - this.appendChild(new PEl().setHtml('Too many users to list')); + this.appendChild(new PEl('warning-truncated-users').setHtml(i18n('warning.optionsview.truncated'))); } return result; diff --git a/src/main/resources/assets/admin/common/js/ui/selector/combobox/ComboBox.ts b/src/main/resources/assets/admin/common/js/ui/selector/combobox/ComboBox.ts index da92ae185..f8a0f167a 100644 --- a/src/main/resources/assets/admin/common/js/ui/selector/combobox/ComboBox.ts +++ b/src/main/resources/assets/admin/common/js/ui/selector/combobox/ComboBox.ts @@ -433,9 +433,9 @@ export class ComboBox selectOptions(options: Option[], silent: boolean = false, keyCode: number = -1): void { assertNotNull(options, 'options cannot be null'); - let added = this.selectedOptionsView.addOptions(options, silent, keyCode); + const added = this.selectedOptionsView.addOptions(options, silent, keyCode); - if(!added) { return; } + if (!added) { return; } this.comboBoxDropdown.markSelections(options); @@ -449,7 +449,7 @@ export class ComboBox return; } - let added = this.selectedOptionsView.addOption(option, silent, keyCode); + const added = this.selectedOptionsView.addOption(option, silent, keyCode); if (!added) { return; } diff --git a/src/main/resources/assets/admin/common/js/util/loader/BaseLoader.ts b/src/main/resources/assets/admin/common/js/util/loader/BaseLoader.ts index 44edaf2de..7f034c491 100644 --- a/src/main/resources/assets/admin/common/js/util/loader/BaseLoader.ts +++ b/src/main/resources/assets/admin/common/js/util/loader/BaseLoader.ts @@ -31,7 +31,7 @@ export class BaseLoader { private comparator: Comparator; - private usePreData: boolean = false; + private useDataPreLoad: boolean = false; constructor(request?: HttpRequest) { this.setRequest(request || this.createRequest()); @@ -54,8 +54,8 @@ export class BaseLoader { let promise: Q.Promise; - if(this.usePreData) { - promise = this.preData(searchString); + if (this.useDataPreLoad) { + promise = this.preLoadData(searchString); } else { promise = this.sendPreLoadRequest(searchString); } @@ -183,12 +183,12 @@ export class BaseLoader { }); } - setUsePreData(bool: boolean): BaseLoader { - this.usePreData = bool; + setUseDataPreLoad(bool: boolean): BaseLoader { + this.useDataPreLoad = bool; return this; } - preData(searchString: string): Q.Promise { + preLoadData(searchString: string): Q.Promise { throw new Error('Must be implemented in deriving classes!'); } diff --git a/src/main/resources/i18n/common.properties b/src/main/resources/i18n/common.properties index 42af44e3a..aa5ac1e6d 100644 --- a/src/main/resources/i18n/common.properties +++ b/src/main/resources/i18n/common.properties @@ -219,3 +219,8 @@ tooltip.filterPanel.show=Show Search Panel tooltip.filterPanel.hide=Hide Search Panel tooltip.header.expand=Click to expand tooltip.header.collapse=Click to collapse + +# +# Warnings +# +warning.optionsview.truncated = The list of users is truncated