Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RedisConnection Check Require Redis Instance Parameter #39

Merged
merged 4 commits into from
Feb 21, 2022
Merged

Make RedisConnection Check Require Redis Instance Parameter #39

merged 4 commits into from
Feb 21, 2022

Commits on Feb 21, 2022

  1. Make RedisConnection Check Require Redis Instance Parameter 

    Redis-rb, the Redis gem used by Rails apps, is deprecating a part of its
API which stores a global Redis connection. See
redis/redis-rb#1064 for context around that
deprecation.

To prepare for when this behavior will be removed, we must update this
application so that Redis will be passed in as an instance to be
checked, because it will not be globally available.
    @kylesnowschwartz
    kylesnowschwartz committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    39920f4 View commit details
    Browse the repository at this point in the history

  2. Rename instance_parameters to redis_instance 

    Simpler name conveys what this variable is
    @kylesnowschwartz
    kylesnowschwartz committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    800c4ef View commit details
    Browse the repository at this point in the history

  3. Add notes to the Readme and Changelog

    @kylesnowschwartz
    kylesnowschwartz committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    4728499 View commit details
    Browse the repository at this point in the history

  4. Update lib/rack/ecg/check/redis_connection.rb 

    Update API documentation with correct types

Co-authored-by: Liam Dawson <liam.dawson@envato.com>
    @kylesnowschwartz @liamdawson
    kylesnowschwartz and liamdawson committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    59b43d0 View commit details
    Browse the repository at this point in the history