Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to PHPUnit for unit tests #248

Merged
merged 39 commits into from
Aug 26, 2018
Merged

Switch to PHPUnit for unit tests #248

merged 39 commits into from
Aug 26, 2018

Conversation

cbornhoft
Copy link
Member

Adding more coverage for all classes as well

cbornhoft and others added 30 commits July 11, 2018 10:14
Add first test using PHPUnit
Add phpunit xml config
Update phpunit version in composer
Update travis php test script
move connect outside of legacy folder
Add setUp() to initialize FluentPDO
Add missing assertion to testJoinShortMulti()
Fix query comparison string in testBasicQuery
Remove initiateFluent() method
these tests are now running as expected
separate tests under appropriate test files
  - used from repo envms/fluent-test

Add phpdoc comments
  - to maintain data integrity for further tests
Remove PDO instance creation

  - includes resetting PDO fetch mode back to FETCH_BOTH, to allow
    FluentPDO\Base::execute() to run properly

Fix query keyword capitalization
Add PHPDoc comments
  - is now old and will not be supported by Fluent 2

Add DB_USER environment variable
Update fluentdb.sql path
  - variadic function parameters are still not supported in hhvm,
    so we'll need to remove hhvm from our test suite for now
  - no one likes Face(GimmeAllYourData)book anyway
Remove PDO instance creation
Remove unused FluentTest class
Update resources require path
@cbornhoft cbornhoft merged commit 80a6809 into master Aug 26, 2018
@cbornhoft cbornhoft deleted the 2.0/unit-tests branch September 27, 2018 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants