-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to PHPUnit for unit tests #248
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add first test using PHPUnit Add phpunit xml config Update phpunit version in composer Update travis php test script
move connect outside of legacy folder
Add setUp() to initialize FluentPDO Add missing assertion to testJoinShortMulti() Fix query comparison string in testBasicQuery Remove initiateFluent() method
these tests are now running as expected
separate tests under appropriate test files
- used from repo envms/fluent-test Add phpdoc comments
- to maintain data integrity for further tests
Update sql timestamp
Remove PDO instance creation - includes resetting PDO fetch mode back to FETCH_BOTH, to allow FluentPDO\Base::execute() to run properly Fix query keyword capitalization Add PHPDoc comments
- is now old and will not be supported by Fluent 2 Add DB_USER environment variable Update fluentdb.sql path
- variadic function parameters are still not supported in hhvm, so we'll need to remove hhvm from our test suite for now - no one likes Face(GimmeAllYourData)book anyway
Remove PDO instance creation Remove unused FluentTest class
- woo!!
Update resources require path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more coverage for all classes as well