From c17fcc19715502471a2770793e8b509dc2bb2270 Mon Sep 17 00:00:00 2001 From: Mike Schore Date: Mon, 5 Aug 2019 16:30:30 -0700 Subject: [PATCH] add todo Signed-off-by: Mike Schore --- library/objective-c/BUILD | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/library/objective-c/BUILD b/library/objective-c/BUILD index a8d1c900ef..a7e22ccf58 100644 --- a/library/objective-c/BUILD +++ b/library/objective-c/BUILD @@ -9,6 +9,9 @@ exports_files([ objc_library( name = "envoy_engine_objc_lib", + # TODO(@goaway): The headers here should really be in hdrs, but this causes them to be imported + # twice due to the way they're pulled into our swift framework rule. We should fix this to + # maintain a valid objc target. srcs = [ "EnvoyEngine.h", "EnvoyEngineImpl.h", @@ -17,12 +20,6 @@ objc_library( "EnvoyHttpStream.m", "EnvoyTypes.h", ], - hdrs = [ - # "EnvoyEngine.h", - # "EnvoyEngineImpl.h", - # "EnvoyHttpStream.h", - # "EnvoyTypes.h", - ], visibility = ["//visibility:public"], deps = ["//library/common:envoy_main_interface_lib"], )