Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add compile flag to have only one api version in Envoy #10198

Closed
junr03 opened this issue Feb 28, 2020 · 4 comments
Closed

api: add compile flag to have only one api version in Envoy #10198

junr03 opened this issue Feb 28, 2020 · 4 comments
Labels
area/configuration no stalebot Disables stalebot from closing an issue

Comments

@junr03
Copy link
Member

junr03 commented Feb 28, 2020

This flag would make it so that only one version, the current version (v3 right now), of the api is compiled in or attempted to be accessed at runtime.

The Envoy Mobile team is interested in this as it relates to non-trivial binary size reduction. More details about our thinking can be found in envoyproxy/envoy-mobile#710.

@junr03 junr03 added no stalebot Disables stalebot from closing an issue area/configuration labels Feb 28, 2020
@junr03
Copy link
Member Author

junr03 commented Mar 10, 2020

cc @htuch @lizan I am back in office, and looking to start a discussion around this. Let me know if you have ideas or work planned in this area as you ramp back up on api versioning work. I'd like to be on the same page as you all in order to prevent making changes here that conflict with your vision for versioning.

@htuch
Copy link
Member

htuch commented Mar 10, 2020

@junr03 this seems like a useful thing to have. I think with some macro magic we can capture/modify the v2 deps in the v3 APIs and no-op them for v3-only builds. When this compile time flag is set, Envoy will need to ensure it only generates v3 transport/resource versions (and only accepts these from any management server).

There's probably some things missing from the above, but happy to discuss further.

@lizan
Copy link
Member

lizan commented Mar 12, 2020

Ideally it is better with less macro magic and just link magic. #9649 should do some of the trick. cc @Shikugawa

@junr03 junr03 mentioned this issue Mar 25, 2020
@mattklein123
Copy link
Member

v2 is going away soon so just closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration no stalebot Disables stalebot from closing an issue
Projects
None yet
Development

No branches or pull requests

4 participants