Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter stats from stats/prometheus #7173

Closed
StrongMonkey opened this issue Jun 5, 2019 · 3 comments
Closed

Filter stats from stats/prometheus #7173

StrongMonkey opened this issue Jun 5, 2019 · 3 comments
Labels
beginner Good starter issues! enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@StrongMonkey
Copy link
Contributor

Issue Template

Title: ability to filter stats from stats/prometheus

Description:
For /stats, there is a way to query(filter) stats based on regexp(adding ?filter). So I am wondering if there are similar expressions for stats/prometheus? I have a use case which I want to query stats from /stats/prometheus outside of envoy and would like to expect some query paramters that can be applied through the endpoint.

@mattklein123 mattklein123 added beginner Good starter issues! enhancement Feature requests. Not bugs or questions. help wanted Needs help! labels Jun 5, 2019
@mattklein123
Copy link
Member

It looks like the filter regex is not passed to the prometheus handler. This should be a very simple change if someone would like to do a beginner PR.

return handlerPrometheusStats(url, response_headers, response, admin_stream);

@StrongMonkey
Copy link
Contributor Author

@mattklein123 thanks for the quick response! I ll put a pr

@mattklein123
Copy link
Member

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner Good starter issues! enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

2 participants