Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review support of AF_UNIX sockets on the Windows port #9571

Closed
wrowe opened this issue Jan 6, 2020 · 5 comments
Closed

Review support of AF_UNIX sockets on the Windows port #9571

wrowe opened this issue Jan 6, 2020 · 5 comments
Labels
area/windows enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@wrowe
Copy link
Contributor

wrowe commented Jan 6, 2020

Windows introduced AF_UNIX domain socket support to the winsock API with the Insider Build 17063 which dropped in Dec '17. This should now be available mainstream on most deployed Server 2019, although this needs to be validated.

https://devblogs.microsoft.com/commandline/af_unix-comes-to-windows/

In porting this support, Envoy should gracefully degrade where the afunix.sys driver is not installed.

@snowp snowp added enhancement Feature requests. Not bugs or questions. area/windows labels Jan 6, 2020
@stale
Copy link

stale bot commented Feb 5, 2020

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Feb 5, 2020
@stale
Copy link

stale bot commented Feb 12, 2020

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

@stale stale bot closed this as completed Feb 12, 2020
@wrowe
Copy link
Contributor Author

wrowe commented Feb 13, 2020

@snowp this remains a placeholder, could you add help wanted (or we can leave it closed for the time being)

@mattklein123 mattklein123 reopened this Feb 13, 2020
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Feb 13, 2020
@mattklein123 mattklein123 added the help wanted Needs help! label Feb 13, 2020
@wrowe
Copy link
Contributor Author

wrowe commented Mar 12, 2020

Note that this is experimentally introduced in #10293 although has yet to be thoroughly reviewed and tested.

@wrowe wrowe changed the title Add support of AF_UNIX sockets to the Windows port Review support of AF_UNIX sockets on the Windows port Mar 13, 2020
@wrowe
Copy link
Contributor Author

wrowe commented Aug 18, 2020

It appears we've made enough progress to consider this placeholder completed.

@wrowe wrowe closed this as completed Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/windows enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

3 participants