Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce L1BlockNumber struct for Ethereum block numbers #2243

Open
t00ts opened this issue Sep 17, 2024 · 0 comments · May be fixed by #2251
Open

Introduce L1BlockNumber struct for Ethereum block numbers #2243

t00ts opened this issue Sep 17, 2024 · 0 comments · May be fixed by #2251
Assignees
@t00ts

Comments

@t00ts
Copy link
Contributor

t00ts commented Sep 17, 2024

Using BlockNumber struct for L1 blocks as well as L2 blocks can cause confusion.

Given it’s just a wrapper around u64, It wouldn’t hurt to have an L1BlockNumber as well so Ethereum blocks are clearly distinguished from Starknet’s in both interfaces and logic.
@t00ts t00ts self-assigned this Sep 17, 2024
@t00ts t00ts linked a pull request Sep 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t00ts t00ts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for L1 to L2 message log syncing eqlabs/pathfinder
1 participant
@t00ts