Skip to content
This repository has been archived by the owner on Aug 11, 2023. It is now read-only.

Aurelia Bundle (jspm) do not include sortable.js #1

Open
gp-slick-coder opened this issue Jan 20, 2017 · 3 comments
Open

Aurelia Bundle (jspm) do not include sortable.js #1

gp-slick-coder opened this issue Jan 20, 2017 · 3 comments
Labels

Comments

@gp-slick-coder
Copy link

gp-slick-coder commented Jan 20, 2017

Hi, nice helper, only the bundle do not include the following file.

My configuration:

module.exports = {
  "bundles": {
    "dist/app-libs": {
      "includes": [
        "aurelia-framework",
         ...
         
        "sortablejs",
        "aurelia-sortablejs"
      ],
      "options": {
        "inject": true,
        "minify": true,
        "depCache": false,
        "rev": true
      }
    }
  }
};

The /jspm_packages/npm/aurelia-sortablejs@1.0.0/sortable.js is still loading separate.

image

Best regards,
George

@gp-slick-coder
Copy link
Author

@gp-slick-coder
Copy link
Author

as a workaround we can include also the sortable.js file in the bundle like:
"aurelia-sortablejs",
"aurelia-sortablejs/sortable"

source: aurelia/bundler#30

@eriklieben eriklieben added the bug label Feb 25, 2017
@KoltesDigital
Copy link
Contributor

Sorry I didn't see this report. I just made a PR to fix it. I disagree with stoffeastrom's comment, the point of bundling is that everything is the bundle is loaded at once, so there is no point knowing whether sortable is loaded before or after index, they are loaded at the same time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants