Skip to content

Commit

Permalink
pythonGH-104898: Add __slots__ to os.PathLike (pythonGH-104899)
Browse files Browse the repository at this point in the history
  • Loading branch information
barneygale committed May 25, 2023
1 parent fea8632 commit bd1b622
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 5 deletions.
2 changes: 2 additions & 0 deletions Lib/os.py
Original file line number Diff line number Diff line change
Expand Up @@ -1079,6 +1079,8 @@ class PathLike(abc.ABC):

"""Abstract base class for implementing the file system path protocol."""

__slots__ = ()

@abc.abstractmethod
def __fspath__(self):
"""Return the file system path representation of the object."""
Expand Down
6 changes: 1 addition & 5 deletions Lib/pathlib.py
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ def __repr__(self):
return "<{}.parents>".format(type(self._path).__name__)


class PurePath(object):
class PurePath(os.PathLike):
"""Base class for manipulating paths without I/O.
PurePath represents a filesystem path and offers operations which
Expand Down Expand Up @@ -707,10 +707,6 @@ def match(self, path_pattern, *, case_sensitive=None):
return False
return True

# Can't subclass os.PathLike from PurePath and keep the constructor
# optimizations in PurePath.__slots__.
os.PathLike.register(PurePath)


class PurePosixPath(PurePath):
"""PurePath subclass for non-Windows systems.
Expand Down
6 changes: 6 additions & 0 deletions Lib/test/test_os.py
Original file line number Diff line number Diff line change
Expand Up @@ -4640,6 +4640,12 @@ class A(os.PathLike):
def test_pathlike_class_getitem(self):
self.assertIsInstance(os.PathLike[bytes], types.GenericAlias)

def test_pathlike_subclass_slots(self):
class A(os.PathLike):
__slots__ = ()
def __fspath__(self):
return ''
self.assertFalse(hasattr(A(), '__dict__'))

class TimesTests(unittest.TestCase):
def test_times(self):
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add missing :attr:`~object.__slots__` to :class:`os.PathLike`.

0 comments on commit bd1b622

Please sign in to comment.