Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with auto-pair brackets in RTL #7

Closed
esm7 opened this issue Nov 28, 2020 · 4 comments
Closed

Issues with auto-pair brackets in RTL #7

esm7 opened this issue Nov 28, 2020 · 4 comments

Comments

@esm7
Copy link
Owner

esm7 commented Nov 28, 2020

When in RTL mode, the Obsidian "Auto pair brackets" feature doesn't work well.
When entering an opening bracket (e.g. opening parenthesis), the cursor ends up after the closing bracket instead of between the brackets. This does not happen when typing the same thing in LTR.
I don't know yet where auto-pairing is implemented (Obsidian/CodeMirror) and where the bug belongs, but maybe this plugin can work around it.

@esm7 esm7 mentioned this issue Dec 14, 2020
@esm7
Copy link
Owner Author

esm7 commented Dec 21, 2020

I reported the bug in CodeMirror and it was fixed immediately: codemirror/codemirror5#6527

@mr-islam
Copy link

Amazing, thank you for your great work on this plugin and also to track down the issue!

So to get this patch from CodeMirror, we must wait for the entire Obsidian app to update the CodeMirror version, right?

@esm7
Copy link
Owner Author

esm7 commented Dec 21, 2020

We need to wait for CodeMirror to release a version and then for Obsidian to update their CM version. In the meantime I'm making a temporary workaround in the plugin that disables the bracket auto-close feature when in RTL.

@esm7
Copy link
Owner Author

esm7 commented Dec 22, 2020

Patched in the new release (0.0.4), auto-pair is now off in RTL and back as configured in LTR.

@esm7 esm7 closed this as completed Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants