Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index.getIndexString parameter definition missed in v0.9.0 #291

Open
mjkangquarry opened this issue Mar 31, 2023 · 0 comments · May be fixed by #292
Open

Index.getIndexString parameter definition missed in v0.9.0 #291

mjkangquarry opened this issue Mar 31, 2023 · 0 comments · May be fixed by #292

Comments

@mjkangquarry
Copy link

"Expected 0 arguments, but got 2." error occur when I try to run a sample in TSX as follows.

    const requestsSeries = new TimeSeries({
      name: 'requests',
      columns: ['time', 'requests'],
      points: requests.map(([d, value]) => [Index.getIndexString('1h', new Date(d)), value]),,
    })

I found current definition is different with real function parameter.

Current wrong definition:
pond/src/index.d.ts

        static getIndexString(): string;

Real function parameter:
pond/src/pond/lib/index.js

    static getIndexString(win, date) {

Please revise it as follows:

         static getIndexString(win: string, date: Date): string;
@mjkangquarry mjkangquarry linked a pull request Apr 3, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant