-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Xiaomi Mi Scale V1 and V2 #209
Comments
More info for parsing data at: https://community.home-assistant.io/t/integrating-xiaomi-mi-scale/9972/81 |
Some |
I hope this may help. Ignore the MiFlora BLE devices.
|
I love to see this supported too. |
I don't own a Xiaomi Mi Scale, but I would buy one if it would be possible to read out data from it using ESPHome. Hope this would be implemented eventually. |
@OttoWinter, do you need some help on this? |
I already implement this feature, How can I upload the code? |
Do you mean a working ESPHome component?
You could create a PR for the main branch or provide the code to test in custom-component folder. |
I am fresh to github. no idea to create PR. I provide the diff code for test. |
I see you're trying to create the PR 🎉️ |
@tsunglung I can confirm that your patch works and my Mi Scale 2 reports the weight (in kgs). For the PR: it is not too difficult but, If you prefer, I could make the request for you. |
@diraimondo Thanks for confirming. |
@tsunglung, OK, for this first approach I think is may be good enough. I'm looking forward into this new PR. If you need testers, please, just say it. :) |
@tsunglung, please, check if it's everything alright. My knowledge on github and C++ are quite limited. :) Thanks for this awesome work! |
@tiagofreire-pt Thanks for creating commit, I checked it and need some modification. |
@tsunglung, can you do it directly or may I need to do it for you? If so, please, point where are the modifications needed. Thanks! |
@tiagofreire-pt you must create only one PR for the whole feature, not a PR for every file. Please fix that. Close PR that will not be required to be merged. |
@glmnet , it seems that I don't have permissions for:
I'm following this FAQ: https://help.github.com/en/articles/merging-a-pull-request |
it's not your role to do that, you are welcome to create a pull request, however as I said your PR is not acceptable as there is one pull request per file and that is not how it's done. see for example this PR esphome/esphome#679 it has 5 file changes We (actually nobody) will accept this. For a clean approach I will suggest you close all your PR and submit a new one with all the changes. Thanks. |
@glmnet, I guess I finally managed to properly submit the PR: esphome/esphome#691 |
How to use this feature in actual project? |
Looks like #1368 finally added the support for the xiaomi scales. Thank you @dckiller51! I don't know if you noticed: https://www.bountysource.com/issues/73647454-add-support-for-xiaomi-mi-scale-v1-and-v2 |
Hello! I am trying to use this feature but no input data appears at esphome logs or at home assistant. My yaml file is:
Can someone help me? |
Hello, Did you put the mac address between 'XX:XX:XX:XX:XX:XX' mac_address: '5C:CA:D3:XX:XX:XX' |
ppanagiotis : same things everything worked for me, but after the update it does not work any more |
@jesserockz As this feature is already implemented (esphome/esphome#1368), I think we can close this issue |
Describe the problem you have/What new integration you would like
There is no easy way to integrate this BLE scale into Home Assistant, on Hassio.
Please describe your use case for this integration and alternatives you've tried:
Integrating weight and BMI on esphome for Home Assistant.
The python code is available for both V1 and V2 Xiaomi Mi Scales: https://github.com/lolouk44/xiaomi_mi_scale/blob/master/Xiaomi_Scale.py
Additional context
It's just a small code increment on xiaomi_ble.cpp parser, already available on esphome.
The text was updated successfully, but these errors were encountered: