Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine_lbgpu broken in debug build #1575

Closed
fweik opened this issue Oct 27, 2017 · 4 comments · Fixed by #2978
Closed

engine_lbgpu broken in debug build #1575

fweik opened this issue Oct 27, 2017 · 4 comments · Fixed by #2978

Comments

@fweik
Copy link
Contributor

fweik commented Oct 27, 2017

The 3pt coupling part is broken. The offending commit is 74d2da9, so it was broken from the beginning. I'll deactivate the 3pt test for now.

@fweik
Copy link
Contributor Author

fweik commented Oct 27, 2017

Removed section from test:

         lbm = espressomd.lb.LBFluid_GPU(
             agrid=1.0,
             tau=S.time_step,
             fric=0.5,
             visc=1.0,
             dens=1.0,
             couple="3pt")
         self.run_and_check(S, lbm, tests_common.abspath("data/engine_lbgpu_3pt.vtk"))

@RudolfWeeber
Copy link
Contributor

What do we do about this?

@fweik
Copy link
Contributor Author

fweik commented Oct 15, 2018

Can you check if this still holds?

@jngrad
Copy link
Member

jngrad commented Jul 8, 2019

Update: 3pt coupling was completely rewritten in #2551, making this bug obsolete.

Re-introducing the engine 3pt coupling test is probably unnecessary since the existing 2pt coupling test covers the same code (lb_calc_particle_lattice_ia_gpu() is now a template for both 3pt and 2pt).

bors bot added a commit that referenced this issue Jul 8, 2019
2978: Remove engine_lbgpu_3pt.vtk r=KaiSzuttor a=jngrad

Closes #1575

Description of changes:
- removed data file for the long-gone (and now redundant) engine lb 3pt coupling test

Co-authored-by: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de>
@bors bors bot closed this as completed in #2978 Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants