Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

algorithm::periodic_fold should check for types #4316

Closed
RudolfWeeber opened this issue Jul 29, 2021 · 1 comment · Fixed by #4955
Closed

algorithm::periodic_fold should check for types #4316

RudolfWeeber opened this issue Jul 29, 2021 · 1 comment · Fixed by #4955
Labels
Core

Comments

@RudolfWeeber
Copy link
Contributor

the implementation

template <typename T, typename I>
std::pair<T, I> periodic_fold(T x, I i, T const &l) {

should check that I is a reference to an integer (and not a pointer to an integer), otherwise the i<limits:;max() comparisson is invalid.
@RudolfWeeber
Copy link
Contributor Author

The Verlet criterion not being centralized, it is also diverged. In some instances skin/2, in others skin is used.

@jngrad jngrad changed the title alogirhtm::periodic_fold should check for types algorithm::periodic_fold should check for types Aug 4, 2021
@jngrad jngrad added the Core label Aug 4, 2021
@RudolfWeeber RudolfWeeber mentioned this issue Jul 16, 2024
Merged
@kodiakhq kodiakhq bot closed this as completed in #4955 Jul 17, 2024
kodiakhq bot added a commit that referenced this issue Jul 17, 2024
@kodiakhq
Restrict valid types for periodic fold (#4955)
3c060c5 
Fixes #4316

Description of changes:
- uses concepts to restrict the types of the template parameters in Algorithm::periodic_fold
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restrict valid types for periodic fold RudolfWeeber/espresso
2 participants
@RudolfWeeber @jngrad