Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for OpenSUSE rpm build #2255

Merged
merged 2 commits into from
Sep 13, 2018
Merged

Fixes for OpenSUSE rpm build #2255

merged 2 commits into from
Sep 13, 2018

Conversation

mkuron
Copy link
Member

@mkuron mkuron commented Sep 11, 2018

Fixes #2254

Candidate for 4.0.1

Seems to not exist on some platforms
@codecov
Copy link

codecov bot commented Sep 12, 2018

Codecov Report

Merging #2255 into python will decrease coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #2255   +/-   ##
======================================
- Coverage      71%     71%   -1%     
======================================
  Files         377     377           
  Lines       18941   18925   -16     
======================================
- Hits        13580   13507   -73     
- Misses       5361    5418   +57
Impacted Files Coverage Δ
...c/core/unit_tests/ParallelScriptInterface_test.cpp 100% <100%> (ø) ⬆️
src/core/cluster_analysis/ClusterStructure.hpp 50% <0%> (-50%) ⬇️
...rc/core/utils/serialization/CUDA_particle_data.hpp 50% <0%> (-50%) ⬇️
src/core/constraints/Constraint.hpp 66% <0%> (-34%) ⬇️
src/core/field_coupling/ForceField.hpp 75% <0%> (-25%) ⬇️
src/core/field_coupling/detail/Base.hpp 80% <0%> (-20%) ⬇️
src/core/field_coupling/PotentialField.hpp 83% <0%> (-17%) ⬇️
src/script_interface/shapes/SpheroCylinder.hpp 83% <0%> (-17%) ⬇️
src/core/short_range_loop.hpp 85% <0%> (-15%) ⬇️
src/core/constraints/ExternalPotential.hpp 80% <0%> (-10%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ac9db4...8e91afb. Read the comment docs.

@mkuron mkuron changed the title Don't require numpy.float128 Fixes for OpenSUSE rpm build Sep 12, 2018
@fweik fweik added the BugFix label Sep 13, 2018
@fweik fweik merged commit e437080 into espressomd:python Sep 13, 2018
@RudolfWeeber RudolfWeeber added this to the Espresso 4.0.1 milestone Oct 15, 2018
RudolfWeeber pushed a commit to RudolfWeeber/espresso that referenced this pull request Oct 15, 2018
@mkuron mkuron deleted the patch-4 branch April 24, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants