Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: VS tracers: don't complain about missing lb for non-virtual par… #2341

Merged
merged 2 commits into from
Oct 29, 2018

Conversation

RudolfWeeber
Copy link
Contributor

Fixes #2204

@@ -39,7 +39,13 @@ void VirtualSitesInertialessTracers::after_force_calc() {
return;
}
#endif
runtimeErrorMsg() << "Inertialess Tracers: No LB method was active.";
for (auto &p : local_cells.particles()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#include <boost/algorithm/cxx11/any_of.hpp>

[...]

if(boost::any_of(local_cells.particles(), [](Particle const& p) {
  return p.p.is_virtual;
}) {
      runtimeErrorMsg() << "Inertialess Tracers: No LB method was active but "
                           "virtual sites present.";
}

is almost a correct English sentence and does short circuit.

@codecov
Copy link

codecov bot commented Oct 28, 2018

Codecov Report

Merging #2341 into python will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #2341    +/-   ##
=======================================
+ Coverage      71%     71%   +<1%     
=======================================
  Files         381     381            
  Lines       18845   18905    +60     
=======================================
+ Hits        13517   13587    +70     
+ Misses       5328    5318    -10
Impacted Files Coverage Δ
src/core/virtual_sites.cpp 80% <0%> (-2%) ⬇️
src/script_interface/lbboundaries/LBBoundary.hpp 75% <0%> (-1%) ⬇️
src/core/grid_based_algorithms/lb.hpp 71% <0%> (-1%) ⬇️
src/core/polymer.cpp 30% <0%> (-1%) ⬇️
...c/core/unit_tests/ParallelScriptInterface_test.cpp 100% <0%> (ø) ⬆️
...rc/core/utils/serialization/CUDA_particle_data.hpp 100% <0%> (ø) ⬆️
src/core/utils/math/tensor_product.hpp 100% <0%> (ø) ⬆️
src/core/cuda_init.cpp 0% <0%> (ø) ⬆️
src/core/MpiCallbacks.cpp 100% <0%> (ø) ⬆️
src/core/PdbParser.cpp 0% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 291664b...95892a0. Read the comment docs.

@fweik fweik added this to the Espresso 4.0.1 milestone Oct 28, 2018
@fweik fweik merged commit a0fdfc6 into espressomd:python Oct 29, 2018
RudolfWeeber pushed a commit to RudolfWeeber/espresso that referenced this pull request Oct 29, 2018
…ut_lb

Core: VS tracers: don't complain about missing lb for non-virtual par…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants