Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed soft sphere cutoff calculation #2505

Merged
merged 4 commits into from
Feb 12, 2019
Merged

Fixed soft sphere cutoff calculation #2505

merged 4 commits into from
Feb 12, 2019

Conversation

fweik
Copy link
Contributor

@fweik fweik commented Feb 11, 2019

  • Added WCA to maxset
  • Fixed cutoff calculation for SOFT_SPHERE
  • Added function to reset all non-bonded interactions.

@fweik fweik requested a review from jngrad February 11, 2019 14:13
@fweik fweik changed the title maintainer: Added WCA to maxset Fixed soft sphere cutoff calculation Feb 11, 2019
@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #2505 into python will increase coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #2505    +/-   ##
=======================================
+ Coverage      72%     72%   +<1%     
=======================================
  Files         485     487     +2     
  Lines       29527   29552    +25     
=======================================
+ Hits        21313   21342    +29     
+ Misses       8214    8210     -4
Impacted Files Coverage Δ
...bonded_interactions/nonbonded_interaction_data.hpp 100% <ø> (ø) ⬆️
...bonded_interactions/nonbonded_interaction_data.cpp 88% <100%> (+2%) ⬆️
src/core/nonbonded_interactions/wca.cpp 100% <0%> (ø)
src/core/nonbonded_interactions/wca.hpp 100% <0%> (ø)
src/core/forces_inline.hpp 73% <0%> (ø) ⬆️
src/core/energy_inline.hpp 58% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6643077...58bad33. Read the comment docs.

Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fweik fweik merged commit a71eb68 into espressomd:python Feb 12, 2019
@fweik fweik deleted the wca branch February 12, 2019 14:31
@RudolfWeeber RudolfWeeber added this to the Espresso 4.0.2 milestone Mar 5, 2019
RudolfWeeber pushed a commit to RudolfWeeber/espresso that referenced this pull request Mar 13, 2019
Fixed soft sphere cutoff calculation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants