BH-gpu magnetostatics: multiple CPU support and refactoring #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #2719 +/- ##
======================================
- Coverage 79% 79% -1%
======================================
Files 508 508
Lines 27050 27047 -3
======================================
- Hits 21590 21587 -3
Misses 5460 5460
Continue to review full report at Codecov.
|
fweik
approved these changes
Apr 12, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 13, 2019
2719: BH-gpu magnetostatics: multiple CPU support and refactoring r=fweik a=psci2195 Fixes #2500 In general, this fix is important cause it allows a user to parallelize both CPU and GPU calculations: EOM integration and magnetostatics respectively. Description of changes: - Correct dipole prefactor broadcasting among the nodes - New test dds-and-bh-gpu.py is running over 4 CPUs: a comparison between BH and DDS gpu calculations. A new test has been needed because we cannot use dds-cpu as a baseline cause it does not support multiple CPUs. - Some technical debt has been caught up here as well: smart pointers based BH, the AMD GPU skip cleanup, per node test seeding. PR Checklist ------------ - [ ] Tests? - [ ] Interface - [ ] Core - [ ] Docs? Co-authored-by: Bogdan Tanygin <b.m.tanygin@gmail.com> Co-authored-by: Brian Tanygin <b.m.tanygin@gmail.com>
Build failed |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Apr 13, 2019
2719: BH-gpu magnetostatics: multiple CPU support and refactoring r=fweik a=psci2195 Fixes #2500 In general, this fix is important cause it allows a user to parallelize both CPU and GPU calculations: EOM integration and magnetostatics respectively. Description of changes: - Correct dipole prefactor broadcasting among the nodes - New test dds-and-bh-gpu.py is running over 4 CPUs: a comparison between BH and DDS gpu calculations. A new test has been needed because we cannot use dds-cpu as a baseline cause it does not support multiple CPUs. - Some technical debt has been caught up here as well: smart pointers based BH, the AMD GPU skip cleanup, per node test seeding. PR Checklist ------------ - [ ] Tests? - [ ] Interface - [ ] Core - [ ] Docs? Co-authored-by: Bogdan Tanygin <b.m.tanygin@gmail.com> Co-authored-by: Brian Tanygin <b.m.tanygin@gmail.com>
Build succeeded |
RudolfWeeber
pushed a commit
to RudolfWeeber/espresso
that referenced
this pull request
Apr 23, 2019
2719: BH-gpu magnetostatics: multiple CPU support and refactoring r=fweik a=psci2195 Fixes espressomd#2500 In general, this fix is important cause it allows a user to parallelize both CPU and GPU calculations: EOM integration and magnetostatics respectively. Description of changes: - Correct dipole prefactor broadcasting among the nodes - New test dds-and-bh-gpu.py is running over 4 CPUs: a comparison between BH and DDS gpu calculations. A new test has been needed because we cannot use dds-cpu as a baseline cause it does not support multiple CPUs. - Some technical debt has been caught up here as well: smart pointers based BH, the AMD GPU skip cleanup, per node test seeding. PR Checklist ------------ - [ ] Tests? - [ ] Interface - [ ] Core - [ ] Docs? Co-authored-by: Bogdan Tanygin <b.m.tanygin@gmail.com> Co-authored-by: Brian Tanygin <b.m.tanygin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2500
In general, this fix is important cause it allows a user to parallelize both CPU and GPU calculations: EOM integration and magnetostatics respectively.
Description of changes:
PR Checklist