Conversion of int-flags to bool in python interface #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #2927 +/- ##
=======================================
- Coverage 83% 82% -2%
=======================================
Files 520 520
Lines 26746 26745 -1
=======================================
- Hits 22328 21959 -369
- Misses 4418 4786 +368
Continue to review full report at Codecov.
|
jngrad
approved these changes
Jun 19, 2019
pkreissl
approved these changes
Jun 19, 2019
|
@fweik: can this be merged? |
fweik
approved these changes
Jun 25, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 25, 2019
2915: Checkpointing: lbboundaries, constraints, auto_update_accumulators +test r=fweik a=RudolfWeeber 2927: Conversion of int-flags to bool in python interface r=fweik a=reinaual Fixes #1942 also changed flags in ELC/MMM2D code 2932: Improve maintainability of build_cmake.sh r=fweik a=jngrad The number of pitfalls in a shell script can be reduced if Google's [Shell Style Guide](https://google.github.io/styleguide/shell.xml#Variable_expansion) is followed: - no more cryptic `if [ ! -z "${var+x}" ]` to test if a variable is undeclared (also, the conditional was used incorrectly and caused the error message `line 94: curl: command not found` in Travis-CI without triggering the trap) - use CMake-like boolean values and test explicitly if a variable is equal to `true` or `false` (we had a mix of `true`, `yes` and empty strings) - every variable is brace-quoted - every string variable is quoted (no more `build_dir="build maxset"; cd ${build_dir}` causing `bash: cd: too many arguments`) Co-authored-by: Rudolf Weeber <weeber@icp.uni-stuttgart.de> Co-authored-by: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de> Co-authored-by: Alexander Reinauer <st144434@stud.uni-stuttgart.de>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1942
also changed flags in ELC/MMM2D code