Remove tutorial 10 and unused LaTeX files #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has been superseded by tutorial 12 constant pH.
They were listed as a dependencies of tutorial 06, but weren't actually included anywhere.
Codecov Report
@@ Coverage Diff @@
## python #3256 +/- ##
======================================
Coverage 85% 85%
======================================
Files 531 531
Lines 25796 25796
======================================
Hits 22169 22169
Misses 3627 3627Continue to review full report at Codecov.
|
|
I just did the same, see #3255 |
jonaslandsgesell
approved these changes
Oct 16, 2019
fweik
approved these changes
Oct 16, 2019
|
bors r=fweik |
bors bot
added a commit
that referenced
this pull request
Oct 17, 2019
3252: Factor out ParticleList r=jngrad a=fweik Follow up on #3251. Description of changes: - Pulling `ParticleList` out of `particle_data.hpp` to get better header disentanglement. 3256: Remove tutorial 10 and unused LaTeX files r=fweik a=jngrad Closes #3211 Description of changes: - removed tutorial 10 - removed unused LaTeX preambles 3257: Remove PDB parser feature r=fweik a=jngrad The consensus offline at the ICP and online in #1441 is to drop support of the PDB parser feature in favor of the dedicated python package MDAnalysis. Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de> Co-authored-by: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de>
|
bors r- |
Canceled (will resume) |
Canceled |
|
bors r=fweik |
bors bot
added a commit
that referenced
this pull request
Oct 17, 2019
3252: Factor out ParticleList r=jngrad a=fweik Follow up on #3251. Description of changes: - Pulling `ParticleList` out of `particle_data.hpp` to get better header disentanglement. 3256: Remove tutorial 10 and unused LaTeX files r=fweik a=jngrad Closes #3211 Description of changes: - removed tutorial 10 - removed unused LaTeX preambles 3257: Remove PDB parser feature r=fweik a=jngrad The consensus offline at the ICP and online in #1441 is to drop support of the PDB parser feature in favor of the dedicated python package MDAnalysis. Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de> Co-authored-by: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3211
Description of changes: