core: particle_data: Fixed removal of bonds to deleted particles. #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #3356 +/- ##
======================================
- Coverage 86% 86% -1%
======================================
Files 537 537
Lines 25283 25283
======================================
- Hits 21756 21754 -2
- Misses 3527 3529 +2
Continue to review full report at Codecov.
|
jonaslandsgesell
approved these changes
Dec 5, 2019
jonaslandsgesell
approved these changes
Dec 5, 2019
KaiSzuttor
approved these changes
Dec 5, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 5, 2019
3356: core: particle_data: Fixed removal of bonds to deleted particles. r=KaiSzuttor a=fweik Fixes #3350. Description of changes: - When removing particles, bonds to the particle are removed also. This was broken and the wrong bonds were removed. This fixes this. This bug was possible to write down because particle ids are `int` and not an explicit type. Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3350.
Description of changes:
This was broken and the wrong bonds were removed. This fixes this.
This bug was possible to write down because particle ids are
intand notan explicit type.