Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROCm 3.0 support #3386

Merged
merged 1 commit into from
Dec 23, 2019
Merged

ROCm 3.0 support #3386

merged 1 commit into from
Dec 23, 2019

Conversation

mkuron
Copy link
Member

@mkuron mkuron commented Dec 20, 2019

They dropped ${HIP_ROOT_DIR}/include from the default include path. Also, I have changed compiler warnings to be consistent with the host compiler.

@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #3386 into python will decrease coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3386   +/-   ##
======================================
- Coverage      86%     86%   -1%     
======================================
  Files         537     537           
  Lines       25287   25287           
======================================
- Hits        21810   21809    -1     
- Misses       3477    3478    +1
Impacted Files Coverage Δ
src/core/particle_data.cpp 97% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba60909...96b27bd. Read the comment docs.

Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jngrad jngrad added this to the Espresso 4.1.3 milestone Dec 21, 2019
@jngrad jngrad merged commit 8fc38b4 into espressomd:python Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants