Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utils: Increase tolerance of matrix vector product test #3417

Closed
wants to merge 1 commit into from

Conversation

RudolfWeeber
Copy link
Contributor

to 8 epsilon

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #3417 into python will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3417   +/-   ##
======================================
  Coverage      86%     86%           
======================================
  Files         538     538           
  Lines       25282   25282           
======================================
  Hits        21805   21805           
  Misses       3477    3477
Impacted Files Coverage Δ
src/utils/tests/matrix_vector_product.cpp 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 102d00c...d6427c8. Read the comment docs.

@jngrad
Copy link
Member

jngrad commented Jan 21, 2020

@junghans does this work for you?

@junghans
Copy link
Member

Didn't help! see log

@jngrad
Copy link
Member

jngrad commented Jan 21, 2020

Oh no, BOOST_CHECK_CLOSE takes a percentage value as the tolerance, epsilon must be multiplied by 100! I thought all those wrong unit tests had been corrected in 4.1, but visibly some of them survived.

@jngrad
Copy link
Member

jngrad commented Jan 21, 2020

@fweik I'll take care of it in #3426

@jngrad
Copy link
Member

jngrad commented Jan 21, 2020

Issue resolved by #3427

@jngrad jngrad closed this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants